From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECCDC433EF for ; Sat, 11 Dec 2021 06:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbhLKGuG (ORCPT ); Sat, 11 Dec 2021 01:50:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40698 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229619AbhLKGuF (ORCPT ); Sat, 11 Dec 2021 01:50:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639205404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5GGR6Yk8NIseTbnIhyrb7g88g2mKiujPf5SqxqWYHYM=; b=T8hLkfXFiP5t79wBOOfxPhHYnjxVIKTEq9Bg8IfyHBWuQB2ydN99WT+Lcxnd80rWxUedki i6uBjbciG5rym/RZOmviuy1RKE9KXOWDziqT/Kx6E6hHhy256D50PNm7xPDd7yTqYWa8ED kyp0OktPyoOjzJF1CQB99bW1vJnPqoM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-396-001TbIFHONWkXtV_cor5HQ-1; Sat, 11 Dec 2021 01:50:01 -0500 X-MC-Unique: 001TbIFHONWkXtV_cor5HQ-1 Received: by mail-lf1-f72.google.com with SMTP id n18-20020a0565120ad200b004036c43a0ddso5124956lfu.2 for ; Fri, 10 Dec 2021 22:50:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:date:mime-version:user-agent:cc :subject:content-language:to:references:in-reply-to :content-transfer-encoding; bh=5GGR6Yk8NIseTbnIhyrb7g88g2mKiujPf5SqxqWYHYM=; b=cVWU3JGtbXIQBt0DaMJhDxalUkACGM86s4miYhF/lruK5c09RMqkRDgpmLJhMjOzkU lK5ZDpbvj80cODE8tnEus1DqfWekAXpQ1Vjg4dQZ4ROSwKVezJM29C+ydZdQNNVJj+Hb sYUrY+6rV3vSNw4c8jHZYegHrafc7TbV/DW3434GjRYMOSAiv6BdddLDk+/3gw+VDqbr FIgF4SoJ5F4kGXv2fEuu1+OrGlmS8CQhwJekY6xrNa7btnZPKmRAVOjfui9bnfEey+wR L9vcbcKTUW8PeA49z1KWE10ea11zcXjwZsGYNJRNXeFF9xzdNMsg6L/abayIpyE+FopF ITNQ== X-Gm-Message-State: AOAM531vEA0kmJzzLWh1WbZ4NSvBUMCEbOaixfSP9CE/+tlPJPorStZJ Cyba/MYYnqUNB7EViPSpEHHojodtTuDX9V4XQdgq3mV8y/fUDcR7kfwVsfiU2mz9/KHUbBj+nT9 TzX3V7cEIvNk9uxZp X-Received: by 2002:a2e:530d:: with SMTP id h13mr17088890ljb.95.1639205399887; Fri, 10 Dec 2021 22:49:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyabu8u398AkOeDvIjdTAMwe4DjCUEMSQhyd/hCvyqhhF33q3z0ei+lXyLKzAfL6cAYrDLWRw== X-Received: by 2002:a2e:530d:: with SMTP id h13mr17088859ljb.95.1639205399593; Fri, 10 Dec 2021 22:49:59 -0800 (PST) Received: from [192.168.0.50] (87-59-106-155-cable.dk.customer.tdc.net. [87.59.106.155]) by smtp.gmail.com with ESMTPSA id u7sm527290lfo.251.2021.12.10.22.49.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 22:49:58 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <35b5bf44-3901-1d75-99d0-43c98def22b9@redhat.com> Date: Sat, 11 Dec 2021 07:49:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Cc: brouer@redhat.com, lorenzo.bianconi@redhat.com, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, shayagr@amazon.com, john.fastabend@gmail.com, dsahern@kernel.org, echaudro@redhat.com, jasowang@redhat.com, alexander.duyck@gmail.com, saeed@kernel.org, maciej.fijalkowski@intel.com, magnus.karlsson@intel.com, tirthendu.sarkar@intel.com, toke@redhat.com Subject: Re: [PATCH v20 bpf-next 23/23] xdp: disable XDP_REDIRECT for xdp multi-buff Content-Language: en-US To: Lorenzo Bianconi , bpf@vger.kernel.org, netdev@vger.kernel.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/12/2021 20.14, Lorenzo Bianconi wrote: > XDP_REDIRECT is not fully supported yet for xdp multi-buff since not > all XDP capable drivers can map non-linear xdp_frame in ndo_xdp_xmit > so disable it for the moment. > > Signed-off-by: Lorenzo Bianconi > --- LGTM you addressed my last review comments. Acked-by: Jesper Dangaard Brouer I do expect followup patches that add support for ndo_xdp_xmit in drivers... > net/core/filter.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 14860931733d..def6e9f451a7 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -4186,6 +4186,13 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp, > struct bpf_map *map; > int err; > > + /* XDP_REDIRECT is not fully supported yet for xdp multi-buff since > + * not all XDP capable drivers can map non-linear xdp_frame in > + * ndo_xdp_xmit. > + */ > + if (unlikely(xdp_buff_is_mb(xdp) && map_type != BPF_MAP_TYPE_CPUMAP)) > + return -EOPNOTSUPP; > + > ri->map_id = 0; /* Valid map id idr range: [1,INT_MAX[ */ > ri->map_type = BPF_MAP_TYPE_UNSPEC; > >