From: Matthieu Baerts <matttbe@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, dsahern@kernel.org, martineau@kernel.org,
geliang@kernel.org
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net v5 2/2] mptcp: count CLOSE-WAIT sockets for MPTCP_MIB_CURRESTAB
Date: Mon, 3 Jun 2024 21:48:02 +0200 [thread overview]
Message-ID: <35b92abd-73a0-4033-b83d-ec84922711f8@kernel.org> (raw)
In-Reply-To: <20240603170217.6243-3-kerneljasonxing@gmail.com>
Hi Jason,
On 03/06/2024 19:02, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
>
> Like previous patch does in TCP, we need to adhere to RFC 1213:
>
> "tcpCurrEstab OBJECT-TYPE
> ...
> The number of TCP connections for which the current state
> is either ESTABLISHED or CLOSE- WAIT."
>
> So let's consider CLOSE-WAIT sockets.
>
> The logic of counting
> When we increment the counter?
> a) Only if we change the state to ESTABLISHED.
>
> When we decrement the counter?
> a) if the socket leaves ESTABLISHED and will never go into CLOSE-WAIT,
> say, on the client side, changing from ESTABLISHED to FIN-WAIT-1.
> b) if the socket leaves CLOSE-WAIT, say, on the server side, changing
> from CLOSE-WAIT to LAST-ACK.
Thank you for the update!
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-06-03 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 17:02 [PATCH net v5 0/2] tcp/mptcp: count CLOSE-WAIT for CurrEstab Jason Xing
2024-06-03 17:02 ` [PATCH net v5 1/2] tcp: count CLOSE-WAIT sockets for TCP_MIB_CURRESTAB Jason Xing
2024-06-03 17:02 ` [PATCH net v5 2/2] mptcp: count CLOSE-WAIT sockets for MPTCP_MIB_CURRESTAB Jason Xing
2024-06-03 19:48 ` Matthieu Baerts [this message]
2024-06-05 11:40 ` [PATCH net v5 0/2] tcp/mptcp: count CLOSE-WAIT for CurrEstab patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b92abd-73a0-4033-b83d-ec84922711f8@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).