From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A77C43218 for ; Fri, 26 Apr 2019 15:14:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F66E206BA for ; Fri, 26 Apr 2019 15:14:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726569AbfDZPOl (ORCPT ); Fri, 26 Apr 2019 11:14:41 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:46182 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbfDZPOk (ORCPT ); Fri, 26 Apr 2019 11:14:40 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-89-CVgzKbF_OB2FJRGt2xjmpQ-1; Fri, 26 Apr 2019 16:14:37 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 26 Apr 2019 16:14:36 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 26 Apr 2019 16:14:36 +0100 From: David Laight To: 'Willem de Bruijn' CC: "netdev@vger.kernel.org" , "davem@davemloft.net" , "idosch@idosch.org" , "Willem de Bruijn" Subject: RE: [PATCH net] packet: validate address length if non-zero Thread-Topic: [PATCH net] packet: validate address length if non-zero Thread-Index: AQHUmkDdSvpkaV9kXkOyGO8KJ3nLv6ZKP8XAgABHlICAABkn4IAB1QMygADfodCAAEMKAIAAFiPAgAGhy/aAAABbYA== Date: Fri, 26 Apr 2019 15:14:36 +0000 Message-ID: <35be28742fbc44af9d77b30d5686de06@AcuMS.aculab.com> References: <20181222215345.128704-1-willemdebruijn.kernel@gmail.com> <28df499bec4146fdbd9d66a6bf7dc621@AcuMS.aculab.com> <62f0a1c528b04e9eaa863179e227165a@AcuMS.aculab.com> <22299f1e84604c36a8a6c4635961cb8a@AcuMS.aculab.com> <24258ef339a7470b84a28854390f1163@AcuMS.aculab.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: CVgzKbF_OB2FJRGt2xjmpQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org RnJvbTogV2lsbGVtIGRlIEJydWlqbg0KPiBTZW50OiAyNiBBcHJpbCAyMDE5IDE2OjExDQo+IE9u IFRodSwgQXByIDI1LCAyMDE5IGF0IDExOjQyIEFNIFdpbGxlbSBkZSBCcnVpam4NCj4gPHdpbGxl bWRlYnJ1aWpuLmtlcm5lbEBnbWFpbC5jb20+IHdyb3RlOg0KPiA+DQo+ID4gT24gVGh1LCBBcHIg MjUsIDIwMTkgYXQgMTA6MzUgQU0gRGF2aWQgTGFpZ2h0IDxEYXZpZC5MYWlnaHRAYWN1bGFiLmNv bT4gd3JvdGU6DQo+ID4gPg0KPiA+ID4gRnJvbTogV2lsbGVtIGRlIEJydWlqbg0KPiA+ID4gPiBT ZW50OiAyNSBBcHJpbCAyMDE5IDE0OjU3DQo+ID4gPiAuLi4NCj4gPiA+ID4gPiBJJ3ZlIGp1c3Qg ZG9uZSBhIGJpdCBvZiBzb2Z0d2FyZSBhcmNoYWVvbG9neS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+ IFByaW9yIHRvIDIuNi4xNC1yYzMgdGhlIHNlbmQgY29kZSBpZ25vcmVkIHNsbF9oYWxlbiwgaXQg d2FzIG9ubHkgc2V0IGJ5IHRoZSByZWNlaXZlIGNvZGUuDQo+ID4gPiA+ID4gU28gaXQgaXMgbm90 IHN1cnByaXNpbmcgdGhhdCBvbGQgYXBwbGljYXRpb24gY29kZSBsZWF2ZXMgaXQgYXMgemVyby4N Cj4gPiA+ID4gPg0KPiA+ID4gPiA+IFRoZSBvbGQgcmVjZWl2ZSBjb2RlIGFsc28gYWx3YXlzIHNl dCBtc2dfbmFtZWxlbiA9IHNpemVvZiAoc3RydWN0IHNvY2thZGRyX2xsKS4NCj4gPiA+ID4gPiBU aGUgcmVjZWl2ZSBjb2RlIG5vdyBzZXRzOg0KPiA+ID4gPiA+ICAgbXNnX25hbWVsZW4gPSBvZmZz ZXRvZihzdHJ1Y3Qgc29ja2FkZHJfbGwsIHNsbF9hZGRyKSArIHNhZGRyLT5zbGxfaGFsZW47DQo+ ID4gPiA+ID4gRm9yIGV0aGVybmV0IHRoaXMgY2hhbmdlcyB0aGUgbXNnX25hbWVsZW4gZnJvbSAy MCB0byAxOC4NCj4gPiA+ID4gPiBBIHNpZGUgZWZmZWN0IChubyBvbmUgaGFzIG5vdGljZWQgZm9y IHllYXJzKSBpcyB0aGF0IHlvdSBjYW4ndCBzZW5kIGEgcmVwbHkNCj4gPiA+ID4gPiBieSBwYXNz aW5nIGJhY2sgdGhlIHJlY2VpdmVkIGFkZHJlc3MgYnVmZmVyLg0KPiA+ID4gPg0KPiA+ID4gPiBH cmVhdCBmaW5kLCB0aGFua3MuIEkgaGFkbid0IHRob3VnaHQgb2YgZ29pbmcgYmFjayB0aGF0IGZh ciwgYnV0DQo+ID4gPiA+IGNsZWFybHkgc2hvdWxkIGluIHRoZXNlIGxlZ2FjeSBjYWxsZXIgcXVl c3Rpb25zLi4NCj4gPiA+DQo+ID4gPiBGb3J0dW5hdGVseSBJIGRpZG4ndCBoYXZlIHRvIGZpbmQg dGhlIHByZS1naXQgc291cmNlcyA6LSkNCj4gPiA+DQo+ID4gPiA+ID4gTG9va2luZyBhdCBpdCBh bGwgYWdhaW4gaG93IGFib3V0Og0KPiA+ID4gPiA+ICAgICAgICAgY2hhciAqYWRkciA9IE5VTEw7 DQo+ID4gPiA+ID4gICAgICAgICAuLi4NCj4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBlcnIgPSAtRUlOVkFMOw0KPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGlmICht c2ctPm1zZ19uYW1lbGVuIDwgb2Zmc2V0b2Yoc3RydWN0IHNvY2thZGRyX2xsLCBzbGxfYWRkcikp DQo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsNCj4g PiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBwcm90byA9IHNhZGRyLT5zbGxfcHJvdG9j b2w7DQo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgZGV2ID0gZGV2X2dldF9ieV9p bmRleChzb2NrX25ldChzayksIHNhZGRyLT5zbGxfaWZpbmRleCk7DQo+ID4gPiA+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKGRldiAmJiBzb2NrLT50eXBlID09IFNPQ0tfREdSQU0pIHsN Cj4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChtc2ctPm1zZ19u YW1lbGVuIDwgZGV2LT5hZGRyX2xlbiArIG9mZnNldG9mKHN0cnVjdA0KPiBzb2NrYWRkcl9sbCwg c2xsX2FkZHIpKQ0KPiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBnb3RvIG91dF91bmxvY2s7DQo+ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBhZGRyID0gc2FkZHItPnNsbF9hZGRyOw0KPiA+ID4gPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgIH0NCj4gPiA+ID4NCj4gPiA+ID4gWWVzLCBnaXZlbiB0aGUgYWJvdmUsIHRoaXMg bG9va3MgZ3JlYXQgdG8gbWUuDQo+IA0KPiBDb21pbmcgYmFjayB0byB0aGlzLiBCb3RoIHRoZSBh Ym92ZSBhbmQgdHdvIHNlcGFyYXRlIHNlbmQvcmVjdiBmaXhlcw0KPiBzZWVtIGZpbmUgdG8gbWUu IERvIHlvdSBoYXZlIGEgcHJlZmVyZW5jZSBlaXRoZXIgd2F5PyBBbmQgZG8geW91IHdhbnQNCj4g dG8gc2VuZCB0aGUgZml4KGVzKSBvciBzaG91bGQgST8NCg0KSSdsbCBsZXQgeW91IGRvIGl0IC0g c2F2ZSBtZSB3b3JraW5nIG91dCBob3cgdG8gZ2V0IHZhbGlkIHBhdGNoZXMgb2ZmDQpteSBMaW51 eCBzeXN0ZW1zIGFuZCBpbnRvIG91dGxvb2sgOi0pDQoNCklmIHlvdSBhcmUgZ29pbmcgdG8gZG8g dGhlIHJlY3YgZml4IHRoZSBzZW5kIG9uZSBjYW4ga2VlcCB0aGUgY2hlY2sNCmFnYWluc3QgdGhl IGZ1bGwgc3RydWN0IHNvY2thZGRyX2xsLg0KDQoJRGF2aWQNCg0KLQ0KUmVnaXN0ZXJlZCBBZGRy ZXNzIExha2VzaWRlLCBCcmFtbGV5IFJvYWQsIE1vdW50IEZhcm0sIE1pbHRvbiBLZXluZXMsIE1L MSAxUFQsIFVLDQpSZWdpc3RyYXRpb24gTm86IDEzOTczODYgKFdhbGVzKQ0K