From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7185B3E5A01 for ; Wed, 13 May 2026 09:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778664287; cv=none; b=hTdRApQ5qKEZ5Y+UpOrIV4JrvEq8Y4C4UhxUM71KwZlOWxZtjRW5fpYKxehBadUlM9Hm9ljyhiy1TKt4np3Gak3ZoZjx0yEKmCx43HYdIXe+kncTfjvGWMj3GZwaotIBgesacts63H7DbIkHNOQ1Mj1nwHKREcgpBwH5Mt3S4W0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778664287; c=relaxed/simple; bh=3sDZx8wJDH/MgYRXdLpJuwCeABozDmK5MVT1YStA8RU=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=YiUuObbbwiBH/dFEaeTa9+hH2rD0/XPD8FojiuZU+MNCVdDFwNvFscIKd/s1dkUaiEgNZQ9KQCXNfJzC+fxqqw2/srPZ0dXd1T2S/xEHegIbp+u56dA5aQJWgaUdS2EH8l1Orh0CtFst7wzAvh8iEgd641kcIAg7chroY0GXJv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im; spf=pass smtp.mailfrom=fastmail.im; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b=dEoBU4oL; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=SCdjyKsc; arc=none smtp.client-ip=202.12.124.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b="dEoBU4oL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SCdjyKsc" Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id 0E8261D00132; Wed, 13 May 2026 05:24:43 -0400 (EDT) Received: from phl-imap-14 ([10.202.2.87]) by phl-compute-10.internal (MEProxy); Wed, 13 May 2026 05:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.im; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1778664283; x=1778750683; bh=SMEJVBMFIpAxx0lGrFUPHaoARljfZ7a9TItOum/BAIE=; b= dEoBU4oL25FFcb3KkvjTUWHX/qb1yNsiC3Cdn9SucIGrdHAHnjZBXgrGR8OuOsDr z80sxaTH1ouzzPYa1TwBCIdlE+5Ljhz5v75uO2zumvZrAbHS6zxaQD6E39jGlvP0 mu9j6r2pmGoKOPP8vF8jzIozGgfzU3wdLI7C4M9EkO+hQq6n9ezGbZZK8NVh+tt2 lnQ8RBRzoiNIvCgrysbSRHuVt1a6BEJdbydPbxKs9ltfeSKCYoCLFaxWhelNyYNn ugpL6Uyk3RuGF4ywjZCfE51bxlwpMnYfRZFgtp+cs2sAshXBeRKGVG7ckO2Z3oSY D5bJaNKUE2BDSYEywmJWkg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778664283; x= 1778750683; bh=SMEJVBMFIpAxx0lGrFUPHaoARljfZ7a9TItOum/BAIE=; b=S CdjyKscZ+7ucKLqkk1DTfPTZy1DxF3GKuK0nreqICx7O/V5UYobZNb+aUJyHxg7d SssyU1uVp1n4wBafsqJRQoItEOe64XE456sd3D8YUgUEijdXrxMT3wU7FrxuIn+5 4+JJ9/PTx55GESjC1tQfNev1mFi7Io99uIfg/lS3khI0wgVWJV1DwYdIGv4uzH58 V/RrggUfFZPeun/dBGrWBz1TJ94EShTXdM4P36yC8Zbn70OZi8rQW9327VbT7kNM UHQwyMW5A01z+5p6BYLZo7W2Bt3hsMOlMaPvvft19+5H6UNdcigQt+Ir/xSrjC1Z UnFtdlzAhgH2TTkE9kAJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduvdegvdelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehlihgt vgcuofhikhhithihrghnshhkrgdfuceorghlihgtvgdrkhgvrhhnvghlsehfrghsthhmrg hilhdrihhmqeenucggtffrrghtthgvrhhnpefhgfevgeeljeegleeiffduheegieehtdff tdetvdffieelkedthfejleejgfeftdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlihgt vgdrkhgvrhhnvghlsehfrghsthhmrghilhdrihhmpdhnsggprhgtphhtthhopedukedpmh houggvpehsmhhtphhouhhtpdhrtghpthhtoheprhgriihorhessghlrggtkhifrghllhdr ohhrghdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpth htoheplhhutghivghnrdigihhnsehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhtfhho mhhitghhvghvsehgmhgrihhlrdgtohhmpdhrtghpthhtohepfihilhhlvghmuggvsghruh hijhhnrdhkvghrnhgvlhesghhmrghilhdrtghomhdprhgtphhtthhopegvughumhgriigv thesghhoohhglhgvrdgtohhmpdhrtghpthhtohepfihilhhlvghmsgesghhoohhglhgvrd gtohhmpdhrtghpthhtohepuggrnhhivghlsehiohhgvggrrhgsohigrdhnvghtpdhrtghp thhtoheprghlihgtvgesihhsohhvrghlvghnthdrtghomh X-ME-Proxy: Feedback-ID: i559e4809:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 029F1C4006E; Wed, 13 May 2026 05:24:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 13 May 2026 11:23:22 +0200 From: "Alice Mikityanska" To: "Gal Pressman" , "Daniel Borkmann" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Xin Long" , "Willem de Bruijn" , "Willem de Bruijn" , "David Ahern" , "Nikolay Aleksandrov" Cc: "Shuah Khan" , "Stanislav Fomichev" , "Andrew Lunn" , "Simon Horman" , "Florian Westphal" , netdev@vger.kernel.org, "Alice Mikityanska" Message-Id: <35cf30b6-f3ac-4af3-816b-53511625d916@app.fastmail.com> In-Reply-To: <6bd88b37-4aeb-4783-8b92-62b38fe8603d@nvidia.com> References: <20260512165648.386518-1-alice.kernel@fastmail.im> <20260512165648.386518-3-alice.kernel@fastmail.im> <6bd88b37-4aeb-4783-8b92-62b38fe8603d@nvidia.com> Subject: Re: [PATCH net-next v4 02/12] udp: gso: Simplify handling length in GSO_PARTIAL Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, May 13, 2026, at 09:53, Gal Pressman wrote: > Hi Alice, > > On 12/05/2026 19:56, Alice Mikityanska wrote: >> From: Alice Mikityanska >> >> Taking further the idea of commit b10b446ce7ad ("udp: gso: Use single >> MSS length in UDP header for GSO_PARTIAL"), simplify the implementation >> and fix the checksum (apparently ignored by hardware anyway). >> >> The mentioned commit started using msslen for uh->len, but still uses >> newlen to adjust uh->check. If the formula for check is fixed, newlen is >> assigned but never used before the loop, and newlen is overwritten after >> the loop. This makes msslen not really necessary, as we can reuse >> newlen, if we don't adjust mss before. The adjustment of mss can be >> simply dropped, because mss is not used anywhere else below. >> >> This brings us back to one variable, drops an unneeded arithmetic for >> mss, and fixes the UDP checksum. >> >> Signed-off-by: Alice Mikityanska >> Cc: Gal Pressman >> Reviewed-by: Willem de Bruijn > > Heads up, this is going to conflict with this fix: > https://lore.kernel.org/netdev/20260513074349.2152146-1-gal@nvidia.com/ Thanks for the heads up! When I submitted mine, your patch wasn't on the list yet, so it's rather the other way around :). Anyway, let's combine our efforts, since we are fixing different aspects of the same area of code. I commented on your patch and suggested to base it on top of mine to avoid creating a new bug with the checksum. If my series doesn't get merged in this iteration, feel free to cherry-pick this commit, it's pretty much independent.