From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Amery Hung <ameryhung@gmail.com>
Subject: Re: pull-request: bpf-next 2025-04-17
Date: Tue, 22 Apr 2025 11:49:26 -0700 [thread overview]
Message-ID: <35f0089e-57a6-4f40-a278-aee4bcfeafac@linux.dev> (raw)
In-Reply-To: <20250421185450.6fde6f84@kernel.org>
On 4/21/25 6:54 PM, Jakub Kicinski wrote:
> On Thu, 17 Apr 2025 11:43:37 -0700 Martin KaFai Lau wrote:
>> 1) bpf qdisc support, from Amery Hung.
>> A qdisc can be implemented in bpf struct_ops programs and
>> can be used the same as other existing qdiscs in the
>> "tc qdisc" command.
>
> Hm, it doesn't build in allmodconfig. Is there a strong reason for it?
The bpf_qdisc.c is enforcing some correctness in the bpf
Qdisc_op.{init,reset,destroy}. For example, it ensures that
qdisc_watchdog_cancel is done in reset/destroy.
It is done by patching the bpf .reset prog and call a kfunc to ensure the
cleanup work is done. Patching with mod kfunc is not supported now. We can
consider to directly use BPF_EMIT_CALL to support mod helper call which should
be simpler verifier changes.
next prev parent reply other threads:[~2025-04-22 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 18:43 pull-request: bpf-next 2025-04-17 Martin KaFai Lau
2025-04-22 1:54 ` Jakub Kicinski
2025-04-22 18:49 ` Martin KaFai Lau [this message]
2025-04-22 9:11 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f0089e-57a6-4f40-a278-aee4bcfeafac@linux.dev \
--to=martin.lau@linux.dev \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).