From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B6329615A for ; Tue, 22 Apr 2025 18:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745347787; cv=none; b=XCyWNE6JoWZ964aMMhtz6RS3Qj5+g2Jw7A+if3iUyIoLNSGEwu5QTBtIYwkybOlAfpKD4tdtmPoL9Jf9qfpxBAQ5IfW8e1D9hs1q3j6tj0ktA6tkb6AoX85dvlSAdEOnxIplfdKsrgOdk9lrU6yDV4KbzCdC/sj1NnWeCPG/l+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745347787; c=relaxed/simple; bh=RWoWEtAf7f+7io/364/s7GfQqzo3lkhR6B0rZgvXcxE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EqW8BJghaLGfrgQvddSXkc3kXMGmBO6MNjYrl7wfDO1AyOh4Joc+u9LtFW7BB2zd2nbdByhJYKxjxJWHPOMTIZZxvQ0j9VNvM5uecxz7zCaaj09j74/AfwyJfpz7UuSQfh07aQHIgkL/t4yr3D3H1qsAqU6sHbi76kNcfu5okDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MtMK2l6Q; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MtMK2l6Q" Message-ID: <35f0089e-57a6-4f40-a278-aee4bcfeafac@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745347771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EhgdkHrICyQW4O8yX6lvFSiloeTjU1LbOh9CjFLXlJs=; b=MtMK2l6QIMZPloVF21C6KQJolqy0G8ntUQXZ4lS9zmRs3ehhc80XRUdfeLE9NqlKFdYzOk d9lXh55ryL0zBNg4j5HVok/jLP0TuiN2ywklnaYc01st5fnLf2KpLJSppDXND/uNCKCjdT VK0Sn+INywGbY6xtbx9S3uFfSsi8QCQ= Date: Tue, 22 Apr 2025 11:49:26 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: pull-request: bpf-next 2025-04-17 To: Jakub Kicinski Cc: David Miller , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Martin KaFai Lau , netdev@vger.kernel.org, bpf@vger.kernel.org, Amery Hung References: <20250417184338.3152168-1-martin.lau@linux.dev> <20250421185450.6fde6f84@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20250421185450.6fde6f84@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 4/21/25 6:54 PM, Jakub Kicinski wrote: > On Thu, 17 Apr 2025 11:43:37 -0700 Martin KaFai Lau wrote: >> 1) bpf qdisc support, from Amery Hung. >> A qdisc can be implemented in bpf struct_ops programs and >> can be used the same as other existing qdiscs in the >> "tc qdisc" command. > > Hm, it doesn't build in allmodconfig. Is there a strong reason for it? The bpf_qdisc.c is enforcing some correctness in the bpf Qdisc_op.{init,reset,destroy}. For example, it ensures that qdisc_watchdog_cancel is done in reset/destroy. It is done by patching the bpf .reset prog and call a kfunc to ensure the cleanup work is done. Patching with mod kfunc is not supported now. We can consider to directly use BPF_EMIT_CALL to support mod helper call which should be simpler verifier changes.