Re: [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection

["Kumar, M Chetan" <m.chetan.kumar@linux.intel.com>]

On 1/25/2023 10:23 AM, Jakub Kicinski wrote:
> On Sat, 21 Jan 2023 19:03:38 +0530 m.chetan.kumar@linux.intel.com wrote:
>> 1> Driver Registers with Devlink framework.
>> 2> Implements devlink ops flash_update callback that programs modem fw.
>> 3> Creates region & snapshot required for device coredump log collection.
> 
> Sounds like these should be 3 patches?

Flashing and coredump feature implementation is kept under single
patch. I can revist and break it into 2 patches to seperate out
flashing and coredump logic. I hope this fine.

> 
>> +	devlink_params_register(dl_ctx, t7xx_devlink_params, ARRAY_SIZE(t7xx_devlink_params));
>> +	value.vbool = false;
>> +	devlink_param_driverinit_value_set(dl_ctx, T7XX_DEVLINK_PARAM_ID_FASTBOOT, value);
>> +	devlink_set_features(dl_ctx, DEVLINK_F_RELOAD);
>> +	devlink_register(dl_ctx);
> 
> Please take the devl_lock() explicitly and use the devl_
> version of those calls.

Ok. will modify it as per your suggestion.

-- 
Chetan