From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 1/4] i40e: clean zero-copy XDP Tx
 ring on shutdown/reset
Date: Fri, 21 Sep 2018 11:17:30 -0700
Message-ID: <36294f373ac94ec5858a54b55b98a5df49c7bffe.camel@intel.com>
References: <20180907081848.5438-1-bjorn.topel@gmail.com>
         <20180907081848.5438-2-bjorn.topel@gmail.com>
         <CAJ+HfNgYwWo1Cmx81SGSRAPEtVzKvogaWSL17vPuorYpx-U-Lw@mail.gmail.com>
Reply-To: jeffrey.t.kirsher@intel.com
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-edLPx3M05ikBW81t3NWS"
Cc: Netdev <netdev@vger.kernel.org>,
        =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn.topel@intel.com>,
        Magnus Karlsson <magnus.karlsson@gmail.com>,
        "Karlsson, Magnus" <magnus.karlsson@intel.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Daniel Borkmann <daniel@iogearbox.net>, ast@kernel.org
To: =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn.topel@gmail.com>,
        intel-wired-lan <intel-wired-lan@lists.osuosl.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga07.intel.com ([134.134.136.100]:4401 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732114AbeIVAHe (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 21 Sep 2018 20:07:34 -0400
In-Reply-To: <CAJ+HfNgYwWo1Cmx81SGSRAPEtVzKvogaWSL17vPuorYpx-U-Lw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--=-edLPx3M05ikBW81t3NWS
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2018-09-21 at 09:35 +0200, Bj=C3=B6rn T=C3=B6pel wrote:
> > --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> > @@ -830,3 +830,33 @@ int i40e_xsk_async_xmit(struct net_device
> > *dev, u32 queue_id)
> >=20
> >          return 0;
> >   }
> > +
> > +/**
> > + * i40e_xsk_clean_xdp_ring - Clean the XDP Tx ring on shutdown
> > + * @xdp_ring: XDP Tx ring
> > + **/
> > +void i40e_xsk_clean_tx_ring(struct i40e_ring *tx_ring)
> > +{
> > +       u16 ntc =3D tx_ring->next_to_clean, ntu =3D tx_ring-
> > >next_to_use;
> > +       struct xdp_umem *umem =3D tx_ring->xsk_umem;
> > +       struct i40e_tx_buffer *tx_bi;
> > +       u32 xsk_frames =3D 0;
> > +
> > +       while (ntc !=3D ntu) {
> > +               tx_bi =3D &tx_ring->tx_bi[ntc];
> > +
> > +               if (tx_bi->xdpf)
> > +                       i40e_clean_xdp_tx_buffer(tx_ring, tx_bi);
> > +               else
> > +                       xsk_frames++;
> > +
> > +               tx_bi->xdpf =3D NULL;
> > +
> > +               ntc++;
> > +               if (ntc > tx_ring->count)
>=20
> This is an off-by-one error, and should be:
> if (ntc =3D=3D tx_ring->count)
>=20
> Can you fix it up, or should I respin the patch?

I can fix it up.

--=-edLPx3M05ikBW81t3NWS
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlulNboACgkQ5W/vlVpL
7c5Caw/9HD/fhfnIIs0wiaKE8Bvs6xrJUbiboOnBXEy89PblAyFCbHgbzpYhZRNC
rRCVQlZjJb8oqFXt4xReh3THqbWlceCaIxKKFPPuZtBAkvntcKxY1la5Eo9J57ll
T9OkxXgoSoTJTRVIgxIbdthPVYVt8BFBEXLGdBXAgVJmtF0DlfBafdtV6BQEkWYx
AyxtTyDc9663s7Y5uGHBhO4Blo9AxIBP/RHXR4M7WVu+dxdnLidoY7DyeSb+c72Z
MVew41ydB3DRy1gWdXCgAshgrfGGRA+aYkx9YFNCvvigKeFPko25W0BZvjyV08uS
a1fVdzKb2N3wSP1LolLXjPulPZ77GyHetUIGIfyLQldCbUZI/H/mSOkHW5Afj2k6
VSMsHOl0x8A9ykmFLTHyGUGode3m5slhmY7nC0fhNd7vbfYOuEw0nXNvh+9im7Qg
5F4Zrx2z305uFBHfhh37YD7HdPisi7FoY0oMeNAQ+7W0ZfsznEK6MhQgKevv/++U
EeAvri9BgkmKE7B9DgAFgvOf1qkTMxv9v1m2PLrTl/IBrWvsDHQVnxLnJwPzOhjg
1A0QIzwB/WemWfWLtlLMCnPT+MNMMCql3kSCHFQ8dzfQzCvV3rHpUU2zHkuULoSh
3vqutH1Ux36T6JrUbAZPQlrcb9iSuIDBYbJR8D8JP/C5H87sIBg=
=+kYs
-----END PGP SIGNATURE-----

--=-edLPx3M05ikBW81t3NWS--