From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, kuba@kernel.org,
syzkaller@googlegroups.com
Subject: Re: [PATCH net] net: increment xmit_recursion level in dev_direct_xmit()
Date: Thu, 18 Jun 2020 21:42:16 -0700 [thread overview]
Message-ID: <363832b8-1d7e-1e9e-8887-ef97d748b0c7@gmail.com> (raw)
In-Reply-To: <20200618.204830.1094276610079682944.davem@davemloft.net>
On 6/18/20 8:48 PM, David Miller wrote:
> From: Eric Dumazet <edumazet@google.com>
> Date: Wed, 17 Jun 2020 22:23:25 -0700
>
>> Back in commit f60e5990d9c1 ("ipv6: protect skb->sk accesses
>> from recursive dereference inside the stack") Hannes added code
>> so that IPv6 stack would not trust skb->sk for typical cases
>> where packet goes through 'standard' xmit path (__dev_queue_xmit())
>>
>> Alas af_packet had a dev_direct_xmit() path that was not
>> dealing yet with xmit_recursion level.
>>
>> Also change sk_mc_loop() to dump a stack once only.
>>
>> Without this patch, syzbot was able to trigger :
> ...
>> f60e5990d9c1 ("ipv6: protect skb->sk accesses from recursive dereference inside the stack")
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Reported-by: syzbot <syzkaller@googlegroups.com>
>
> Applied and queued up for -stable.
>
> I only noticed after pushing this out the missing "Fixes: " prefix, but not
> much I can do about this now sorry :-/
Oh right, sorry for this.
prev parent reply other threads:[~2020-06-19 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 5:23 [PATCH net] net: increment xmit_recursion level in dev_direct_xmit() Eric Dumazet
2020-06-19 3:48 ` David Miller
2020-06-19 4:42 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=363832b8-1d7e-1e9e-8887-ef97d748b0c7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox