From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6342E381AFC for ; Wed, 17 Jun 2026 06:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781679049; cv=none; b=ZbUL6B2oGRZmH0fF8T74jB3C6cLNk6Sv4Z6mtANTL94z7xN24HsZcRiAU58kfjwPglgfbVuLdiiGQAsBZcaykdr7rOl6S8udm6rxSdJeYpmdz1M+rwVMDCT25sJff57it9LTBpS+KZ3h0ca04yfdZRxAJxxnckiaufgIiauqNr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781679049; c=relaxed/simple; bh=C7YFZCCu1dOeCsLg6DoF+9ZVtNHvPRq+h+Zo6dLBmB0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DuNjliq3HxMeytqYFNSxprO49CLFXscHSgPwTSFG1OC9WbXuTKQUFJGbYbuzMqxgtKPf+e29kVkyh/Qizq7bE7NwS4tjvn0Y9J60iyj7yUJ5jdEsFRbZ1cgOSFiNjSkH1Awl3AMqWDzarJKb/8SRDRGgchkM/9qL8AaLrSjWTXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WCqJCXi9; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WCqJCXi9" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-46066e640easo3288185f8f.1 for ; Tue, 16 Jun 2026 23:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781679047; x=1782283847; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Trq1GUdrJefwFDKO73LEpHAox6MBJ2GUwy+Cih5DopY=; b=WCqJCXi9yibRSJ5D2QIBg96wVMVBsltG7hqEhWSiMMjpnepNe7JZcNqou8TvpStsC5 0O2VRVRDsZr8u6wYnVE9CMPpGHdot2XRhpzV5dySGs2ikkqUNBVPnz3FHJ7bZ1+V+TEP aihcJCNbrHAZozcBZVodaoqGw+qhMxEUK8KO5H5WWYnmMpFxSCOLQKtK/fGUyB/z8sxB ijoPo6PGn3OTd36WIVXzLOKNiutmb6rQoKwKI6s7cRcJ/20qJnOCoCpTeuT7D0VkSDkp 2SON5gb7viS29bcJumAjOzlr6/idKj4TDUPRF4JNb8d4dR/xoIkC+K73wDSZqiZ4ZhXu aoVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781679047; x=1782283847; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Trq1GUdrJefwFDKO73LEpHAox6MBJ2GUwy+Cih5DopY=; b=Y4krXeAh4vce4z1EoSTncxr9WxhW53wSClrwNJ4Jyrbq2A50AbtFNWVOMdDluuhf+y 1pW78N6ac3z1oy4HwgcRmU1kQ1vd7Vrpx3m0WuypJV3LKLkFYWg0NF2Jd5bxHu9JncoY bOAfPlisgJLrbHdenMlBncvFrZh+GYhyUQRD1NrH4YjkiJUNTjbirpTyr0QZf0xPQPuR To2ZkF9LSpswTwLkV3+pzv4nZJ2XsBNOZEYiOuYs4shqD76Bgyu1fhoKBHwSNluOTQNP vKB3pCcJ/7vpDGKJ7rj37aDC9lC0Mt3F2y6nDRdsbzx4VhBtJB2sonOU+3v1x/tf7gQH R8VQ== X-Forwarded-Encrypted: i=1; AFNElJ8mnKFxu6nFAPPAUZF7lLJ6ohtITkpuIJy/IfwQ5NI7gV9PGBlHHREpzaI0jcGWCSyTpp7fXXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzwyaNcF68cCnXFLurYOyz9+4t7tSj/ejI8jQKppQPPd08d9hmR CV8sMzBZXU/YNlyM6h0N9LBpJkAwbLjgmAYTZvJNWW5aoE50C1zDuZmV X-Gm-Gg: Acq92OEtg/SKsgUxVFZ9Ck9ecH4URgeCcLSY1fsCkorPLVYOcMqrHquoqDvYlFSyZxX heJxJpngLPGJD0pvxf7wARQlby1PF++qobHwSvRTAGqLA60Q1OYQQYipW3z5ZYmr6MGxDHZCArX MXW/SNTPuyZgPbAjs1m29UYSBjsboaae4OjpBpEptCYC2UIyfOwNAnoNQOR0rssD72/oFMjFNkB 1217kior55GicQqjuHyLosBzVcW3+uVmgtEHlwA8/0txCvpJmEBOlgnzo2n5ENk+my7jynTDN5v KdvRetO7Vzc1k8RvQwov5Hqgf8TFZVrWKnFWBsLrKJHuPOh7Uf6QLSuq6n+MCr0TgeJdKKsjsh3 dUBxc4LNRCdEhZS7UcaWQ7di2iTxkpe2QgUTd8wG+KRJi3v9TZTX7lel/cAins/7rKP/FPDgTIq AZTJndi8+WSbE0GDSQ8Q9Q1vvP2cGWdQJpZy/Hd98q6ilbrBniWxztm0EprcDng2mBYBmTd/HV3 hXtCeOXNwL8oLc= X-Received: by 2002:a05:600c:a111:b0:490:e5c1:b89d with SMTP id 5b1f17b1804b1-492333ffd28mr36380385e9.0.1781679046294; Tue, 16 Jun 2026 23:50:46 -0700 (PDT) Received: from ?IPV6:2001:9e8:f13a:1701:b918:4041:7c7d:eb1d? ([2001:9e8:f13a:1701:b918:4041:7c7d:eb1d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49233bf0881sm41430175e9.2.2026.06.16.23.50.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 23:50:45 -0700 (PDT) Message-ID: <36668b89-77ef-406f-9edc-ed57a025754b@gmail.com> Date: Wed, 17 Jun 2026 08:50:44 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: pse-pd: add bindings for Realtek/Broadcom PSE MCU Content-Language: en-US To: Rob Herring Cc: Oleksij Rempel , Kory Maincent , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Golle , =?UTF-8?Q?Bj=C3=B8rn_Mork?= References: <20260612132944.460646-1-jelonek.jonas@gmail.com> <20260612132944.460646-2-jelonek.jonas@gmail.com> <20260615212959.GA1679454-robh@kernel.org> From: Jonas Jelonek In-Reply-To: <20260615212959.GA1679454-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Rob, On 15.06.26 23:29, Rob Herring wrote: > On Fri, Jun 12, 2026 at 01:29:41PM +0000, Jonas Jelonek wrote: >> [...] >> >> +properties: >> + compatible: >> + enum: >> + - realtek,pse-mcu-rtk > The "rtk" feels redundant. In the full Realtek case yes. Do you have a suggestion to improve that? >> + - realtek,pse-mcu-bcm > "brcm" is the standard vendor prefix, so use that instead of "bcm". > Though who defined the protocol in this case? Realtek or Broadcom? In > the latter case, I'd argue that "brcm" should be the vendor prefix. I'll switch to brcm. As Daniel already mentioned, Realtek defines the firmware and thus the protocol, in both cases. >> + >> + reg: >> + maxItems: 1 >> + >> + power-supply: >> + description: Regulator supplying the PoE power rail. >> + >> + enable-gpios: >> + maxItems: 1 >> + >> + realtek,i2c-protocol: >> + $ref: /schemas/types.yaml#/definitions/string >> + enum: [ i2c, smbus ] >> + description: | >> + Wire framing the MCU firmware expects on the I2C bus. "smbus" means >> + reads carry a leading command byte (0x00) and a repeated start; "i2c" >> + means bare 12-byte writes and reads with no command prefix. Only >> + applies to the Realtek I2C attachment. > I tend to think this should be distinguished by the compatible string. > That would simplify the schema given it only applies to one of the > compatible strings. In theory this could also apply to the Broadcom dialect, however I didn't have a device with that variant on my desk. If you would go with separate compatibles, do you thought about something like "realtek,pse-mcu-rtk-i2c" and "realtek,pse-mcu-rtk-smbus" (given we stick with rtk) ? > Rob Best regards, Jonas