From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [bpf PATCH 0/2] tls, sockmap, fixes for sk_wait_event Date: Wed, 22 Aug 2018 23:52:15 +0200 Message-ID: <3676efa3-e8ea-1748-a661-0d58cc943833@iogearbox.net> References: <20180822153314.27968.72499.stgit@john-Precision-Tower-5810> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net To: John Fastabend , ast@kernel.org, davejwatson@fb.com Return-path: Received: from www62.your-server.de ([213.133.104.62]:41589 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbeHWBS5 (ORCPT ); Wed, 22 Aug 2018 21:18:57 -0400 In-Reply-To: <20180822153314.27968.72499.stgit@john-Precision-Tower-5810> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 08/22/2018 05:37 PM, John Fastabend wrote: > I have been testing ktls and sockmap lately and noticed that neither > was handling sk_write_space events correctly. We need to ensure > these events are pushed down to the lower layer in all cases to > handle the case where the lower layer sendpage call has called > sk_wait_event and needs to be woken up. Without this I see > occosional stalls of sndtimeo length while we wait for the > timeout value even though space is available. > > Two fixes below. Thanks. > > --- > > John Fastabend (2): > tls: possible hang when do_tcp_sendpages hits sndbuf is full case > bpf: sockmap: write_space events need to be passed to TCP handler > > > kernel/bpf/sockmap.c | 3 +++ > net/tls/tls_main.c | 9 +++++++-- > 2 files changed, 10 insertions(+), 2 deletions(-) Applied to bpf, thanks John!