From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D778C282C0 for ; Wed, 23 Jan 2019 17:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8CBB21874 for ; Wed, 23 Jan 2019 17:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726213AbfAWRee (ORCPT ); Wed, 23 Jan 2019 12:34:34 -0500 Received: from gateway31.websitewelcome.com ([192.185.144.96]:43602 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbfAWRed (ORCPT ); Wed, 23 Jan 2019 12:34:33 -0500 X-Greylist: delayed 1360 seconds by postgrey-1.27 at vger.kernel.org; Wed, 23 Jan 2019 12:34:33 EST Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 90F2E170644 for ; Wed, 23 Jan 2019 11:11:41 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id mM3xgO0mJiQermM3xghN5D; Wed, 23 Jan 2019 11:11:41 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=49070 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gmM3x-000EWe-4D; Wed, 23 Jan 2019 11:11:41 -0600 Subject: Re: [PATCH net-next] intel: Mark expected switch fall-throughs To: jeffrey.t.kirsher@intel.com, "David S. Miller" Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190123074849.GA24230@embeddedor> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Message-ID: <368769c1-bb6c-b137-14c4-ef0ade488c2e@embeddedor.com> Date: Wed, 23 Jan 2019 11:11:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1gmM3x-000EWe-4D X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.130.205]:49070 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Jeffrey, On 1/23/19 11:04 AM, Jeff Kirsher wrote: > On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/net/ethernet/intel/igb/e1000_82575.c:636:6: warning: this >> statement may fall through [-Wimplicit-fallthrough=] >> drivers/net/ethernet/intel/igb/igb_main.c:6710:6: warning: this >> statement may fall through [-Wimplicit-fallthrough=] >> drivers/net/ethernet/intel/i40e/i40e_xsk.c:237:3: warning: this >> statement may fall through [-Wimplicit-fallthrough=] >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++- >> drivers/net/ethernet/intel/igb/e1000_82575.c | 2 +- >> drivers/net/ethernet/intel/igb/igb_main.c | 2 +- >> 3 files changed, 4 insertions(+), 3 deletions(-) > > NAK on the igb changes. There is already a "fall through" code comment > which is fine, adding a hyphen does not make the comment any more > readable. > Those comments are not fine. They trigger the warnings I mention in the commit log. With this patch such warnings are fixed. Notice that warning level 3 was used: -Wimplicit-fallthrough=3 Thanks -- Gustavo