From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD9AC282CE for ; Fri, 5 Apr 2019 21:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DEAF206BA for ; Fri, 5 Apr 2019 21:54:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XZkQZCvD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726419AbfDEVyr (ORCPT ); Fri, 5 Apr 2019 17:54:47 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:43550 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726124AbfDEVyq (ORCPT ); Fri, 5 Apr 2019 17:54:46 -0400 Received: by mail-yb1-f195.google.com with SMTP id d20so2961615ybm.10 for ; Fri, 05 Apr 2019 14:54:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1T12cQMXUFeAj8HInzEkjyD58aPlxiXC0Sqf8MMJXXI=; b=XZkQZCvD/QD+JLW+Na0IVG40RPZLezq4vKchQMPIOa29jhuZ/8wvUQPXcyl0xa2Txb wUSYS3dCsTKbncuySB5RrtWeM4xLHkiH59SZqNrhfUrskZK9oreHqZIqfeyEwre8ZaHb ZVZEQ9DTDmZlRoiVvmoe/ruaIIV61OkgfPVC/ZvZTyeTzHSQrJUwpBHUqnVm55SA+7tG iZ3BlbSQihZcAkR2hdhxz6JiT5eTQbshDOw9NL9yg0Yx+CxuYdtdNbQpQXo5LocMTe5V cAurwkeRirqQSEQ3aHEdo9tqdzwLr45A+muLvcRuw/UpTm/5QoeI4fXp/9DUUcA82HcB k4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1T12cQMXUFeAj8HInzEkjyD58aPlxiXC0Sqf8MMJXXI=; b=UNvFgERUmMk3T8ykQs7qDqTwALJzMSsb5SmCjyqGuWfS08ETIEGGb03HjQatYLAs84 zcVekVGPT+crq0p0g5guXqAwtX2L0KlUHIcrn4fl7qOsAO9b5cAdGmKzVvV2fU8LFrmj pDl5LtSm8yFexZ3Vq3tuKsa6Eqsg4YV007v/bjdLmOZO2z2vfsRzGpYLNnUJtjCwuISk 0h8q385apSAAwOm78h0Ip2fUNLsf5Dd5IVlt0Mf8JAnZYK7m2eizPFYTdtO8+GsJqqZZ iFlu0L0SYVi5HurVwHwGr9Q8aHz1QMcFY0nUqsRtlfgtehmvzgSN2oRMCARVPrE4PReb M2oQ== X-Gm-Message-State: APjAAAWjKAldIkYrTyMFHufTZzVrGjK/ihtDsCevY7uveM6o6DiDfWAq 0+nwm3EGCySSLM+KdoLklYYeUq5u X-Google-Smtp-Source: APXvYqxw6un37vl99hk4iojr0/R7bFSkMYz9xrzmrh9HudWdAhC0kCuY3rUvwSpWD4KL+7sHH6TkJw== X-Received: by 2002:a25:2c93:: with SMTP id s141mr13410855ybs.440.1554501285138; Fri, 05 Apr 2019 14:54:45 -0700 (PDT) Received: from [10.67.49.72] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id k125sm14075592ywb.26.2019.04.05.14.54.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 14:54:44 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve link partner capability detection To: Heiner Kallweit , Andrew Lunn Cc: David Miller , "netdev@vger.kernel.org" References: <20190405212734.GE27350@lunn.ch> <626265b0-3020-8971-1a11-0fce46075bef@gmail.com> <43505b5e-084d-0fe5-32b1-fc71358a4cda@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <36b1ecfb-4cde-9c48-3d1b-6304418991f8@gmail.com> Date: Fri, 5 Apr 2019 14:54:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <43505b5e-084d-0fe5-32b1-fc71358a4cda@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/19 2:52 PM, Heiner Kallweit wrote: > On 05.04.2019 23:38, Heiner Kallweit wrote: >> On 05.04.2019 23:27, Andrew Lunn wrote: >>>> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, >>>> + phydev->supported)) >>>> + phydev->is_gigabit_capable = 1; >>>> + if (linkmode_test_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, >>>> + phydev->supported)) >>>> + phydev->is_gigabit_capable = 1; >>>> + >>> >>> What i'm trying to get at is, why do we need this bit of the patch? >>> Why do we need this flag? The hardware should tell us if it can do >>> gigabit. >>> >> The code to query BMSR_ESTATEN and MII_ESTATUS is in genphy_read_status. >> However we also have to cover the case that this function isn't used. >> Therefore I query phydev->supported before the speed could be limited. >> (relying on the PHY driver not lying about gigabit capability) >> This part of the patch is directly before of_set_phy_supported(). >> >> I just see that we can re-use is_gigabit_capable also in >> genphy_config_advert. >> >> Of course I can read in every place the hardware for gigabit support. >> But IMO this creates unnecessary code duplication. >> > I just see that we can reuse is_gigabit_capable also in > genphy_config_advert(). > > And when checking occurrences of BMSR_ESTATEN there seems to be more > work waiting: In swphy BMSR_ESTATEN is set, but MII_ESTATUS isn't > configured. It just works by chance becausing reading this register > returns the default 0xffff. It is not clear to me what we are trying to optimize for here, given everything is pretty much a slow path anyway. I am concerned though about mis-behaving PHYs where caching of BMSR_ESTATEN could result in incorrect behaviors, I don't have any data to back that claim, but reading the registers should always be the safest way to determine what HW is capable of (famous last words). Not feeling strongly about either direction though... -- Florian