From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6F8C10F06 for ; Sat, 6 Apr 2019 10:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05C29218C3 for ; Sat, 6 Apr 2019 10:24:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="bh7mqx4D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbfDFKYg (ORCPT ); Sat, 6 Apr 2019 06:24:36 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:38169 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbfDFKYf (ORCPT ); Sat, 6 Apr 2019 06:24:35 -0400 Received: by mail-lf1-f67.google.com with SMTP id a6so6140282lfl.5 for ; Sat, 06 Apr 2019 03:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0B2T93URAhgkJumCufvQgsIA73utiusJRcpc3egwJ3w=; b=bh7mqx4Dk6f8JGmWpEyE1WEoykl+7YYcpjdshasbN5gUWF1DQkQ+saSf5pYKspd0ks 9lzneFQTxPofVNeIlAyPVH0i5m5wMYgkVes8wNDoFp7BoFm9U4f7HPH5etAGHhXCapgi nQKVpD6sPyRH0mmUqHoEhwtN0sY2olKexpbyi8n2YKDOMzAf6Y9WxWz/nMy0iIHtP+x2 rEGTLwsLvUR3a8nNdAKClh8PJgZrUd1GpKk255faE0gAr03ez+oFKn1sPURrjP6jad5K JqqMjFeVrSJxnPBjr06IwXzL5Cw5E050prXoXpMeAvcc1NkszCowLyg5Snut4t954yFZ /dAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0B2T93URAhgkJumCufvQgsIA73utiusJRcpc3egwJ3w=; b=QL4SPUzyihyNbTfcXlykpXLEnGgEGPMozMSlB5ToFhBGKal2hvioCLn/FEfinoLYCW 6oDGUVOj9AbmmdszCcLXy74BBEaRKQWoyHgoiOnu1VFVg0qt1XsggbV4HQDDjY3EJRHf fx0PL1S2is0KMJArdpkQ89BcoZ/A5AHWARp0WVlUrxPu5cCJJrIVSkquYo5z5iXabU3I X++B7nQfvtHvGfa1x/Qk+brX9jkV+M3aFOzrTVnbsfpjxqgdvq+ydLVqKPlT9S0wbSi7 w1Hh6ibjxOkTU0BSF+T8e7trwG2L4eKFh+Ev1pcnMsGjK/5mW7VUzt8ITy1JYIEoTojB Mc6Q== X-Gm-Message-State: APjAAAUhYaCy9maGRK+iuiJzKKam5QWh11HFZcNjpGiSjaE4JsetMhgN njjRl2eQEEpjEVhfMOhqNEBFgg== X-Google-Smtp-Source: APXvYqxPg2maS6hIFXQrqgAZHG5hl6JCOOnw2lWbLYw42o3CcmK36QiKAT3Au6HlUb4wVR3vdqDlcQ== X-Received: by 2002:ac2:5082:: with SMTP id f2mr9991211lfm.71.1554546273571; Sat, 06 Apr 2019 03:24:33 -0700 (PDT) Received: from [10.102.31.166] ([81.16.143.135]) by smtp.gmail.com with ESMTPSA id q5sm4914656lfm.16.2019.04.06.03.24.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 03:24:32 -0700 (PDT) Subject: Re: [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one To: megous@megous.com, linux-sunxi@googlegroups.com, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linus Walleij Cc: Icenowy Zheng , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Naveen Gupta , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-gpio@vger.kernel.org References: <20190405234514.6183-1-megous@megous.com> <20190405234514.6183-7-megous@megous.com> From: Sergei Shtylyov Message-ID: <36e1e65b-5a8f-f8ae-6c33-07c30beada17@cogentembedded.com> Date: Sat, 6 Apr 2019 13:24:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190405234514.6183-7-megous@megous.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 06.04.2019 2:45, megous@megous.com wrote: > From: Icenowy Zheng > > The PHY selection bit also exists on SoCs without an internal PHY; if > it's set to 1 (internal PHY) then the MAC will not make use of any PHY. > > This problem appears when adapting for H6, which has no real internal > PHY (the "internal PHY" on H6 is not on-die, but on a co-packaged AC200 > chip, via RMII interface at GPIO bank A), but the PHY selection bit is > set. > > Force the PHY selection bit to 0 when no external PHY to select this > problem. "Select this problem" sound weird... > Signed-off-by: Icenowy Zheng > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index e3e3dc44b33b..bd340e77b2ea 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -908,6 +908,11 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) > * address. No need to mask it again. > */ > reg |= 1 << H3_EPHY_ADDR_SHIFT; > + } else { > + /* For SoCs without internal PHY the PHY selection bit should be > + * set to 0 (external PHY). > + */ > + reg &= ~(H3_EPHY_SELECT); No () should be needed here, add () around the macro body if still needed. [...] MBR, Sergei