From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44520 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750767AbeCPIph (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 16 Mar 2018 04:45:37 -0400
Subject: Re: [bpf-next V2 PATCH 10/15] xdp: rhashtable with allocator ID to
 pointer mapping
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org,
        =?UTF-8?B?QmrDtnJuVMO2cGVs?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com, eugenia@mellanox.com,
        John Fastabend <john.fastabend@gmail.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>, galp@mellanox.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
References: <152051439383.7018.11827926732878918934.stgit@firesoul>
 <152051451209.7018.14564668423312296696.stgit@firesoul>
 <ca2b27dc-243b-5b2e-6b05-a273c9e39aec@redhat.com>
 <20180309103725.234ff988@redhat.com>
 <14397dda-c469-f8bd-a1fb-fe8cc6c28e82@redhat.com>
 <20180309170735.5573f4e0@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <36f68a76-4c73-e0d1-b97b-645393e006ee@redhat.com>
Date: Fri, 16 Mar 2018 16:45:30 +0800
MIME-Version: 1.0
In-Reply-To: <20180309170735.5573f4e0@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 2018年03月10日 00:07, Jesper Dangaard Brouer wrote:
> On Fri, 9 Mar 2018 21:07:36 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>>>>> Use the IDA infrastructure for getting a cyclic increasing ID number,
>>>>> that is used for keeping track of each registered allocator per
>>>>> RX-queue xdp_rxq_info.
>>>>>
>>>>> Signed-off-by: Jesper Dangaard Brouer<brouer@redhat.com>
>>>> A stupid question is, can we manage to unify this ID with NAPI id?
>>> Sorry I don't understand the question?
>> I mean can we associate page poll pointer to napi_struct, record NAPI id
>> in xdp_mem_info and do lookup through NAPI id?
> No. The driver can unreg/reg a new XDP memory model,

Is there an actual use case for this?

>   without reloading
> the NAPI and generate a new NAPI id.
>

We could still do this by e.g a allocator pointer protected by RCU I think?

Thanks