netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Rob Herring <robh@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Felix Fietkau <nbd@nbd.name>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	"Shayne Chen" <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>,
	"Kalle Valo" <kvalo@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	Biao Huang <biao.huang@mediatek.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples
Date: Mon, 30 May 2022 11:03:59 +0200	[thread overview]
Message-ID: <3704e284-3fd0-b073-9a3b-68ae2e966181@microchip.com> (raw)
In-Reply-To: <20220526014149.2872762-1-robh@kernel.org>

On 26/05/2022 at 03:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples. Fix the warnings by removing
> spurious properties or adding missing properties to the schema.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/net/cdns,macb.yaml           | 1 -
>   Documentation/devicetree/bindings/net/mediatek,net.yaml        | 3 +++
>   Documentation/devicetree/bindings/net/mediatek-dwmac.yaml      | 3 +++
>   .../devicetree/bindings/net/wireless/mediatek,mt76.yaml        | 2 +-
>   4 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 337cec4d85ca..86fc31c2d91b 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -191,7 +191,6 @@ examples:
>                       clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
>                       #address-cells = <1>;
>                       #size-cells = <0>;
> -                    #stream-id-cells = <1>;
>                       iommus = <&smmu 0x875>;
>                       power-domains = <&zynqmp_firmware PD_ETH_1>;
>                       resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>;

For cdns,macb.yaml:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Rob. Best regards,
   Nicolas

> diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> index 699164dd1295..f5564ecddb62 100644
> --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml
> @@ -27,6 +27,9 @@ properties:
>     reg:
>       maxItems: 1
> 
> +  clocks: true
> +  clock-names: true
> +
>     interrupts:
>       minItems: 3
>       maxItems: 4
> diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> index 901944683322..61b2fb9e141b 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml
> @@ -58,6 +58,9 @@ properties:
>         - const: rmii_internal
>         - const: mac_cg
> 
> +  power-domains:
> +    maxItems: 1
> +
>     mediatek,pericfg:
>       $ref: /schemas/types.yaml#/definitions/phandle
>       description:
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 249967d8d750..5a12dc32288a 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -51,7 +51,7 @@ properties:
>       description:
>         Specify the consys reset for mt7986.
> 
> -  reset-name:
> +  reset-names:
>       const: consys
> 
>     mediatek,infracfg:
> --
> 2.34.1
> 


-- 
Nicolas Ferre

  reply	other threads:[~2022-05-30  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  1:41 [PATCH] dt-bindings: net: Fix unevaluatedProperties warnings in examples Rob Herring
2022-05-30  9:03 ` Nicolas Ferre [this message]
2022-05-31 15:20 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3704e284-3fd0-b073-9a3b-68ae2e966181@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=biao.huang@mediatek.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).