From: Alexandre Torgue <alexandre.torgue@st.com>
To: Christophe Roullier <christophe.roullier@st.com>,
<robh@kernel.org>, <davem@davemloft.net>, <joabreu@synopsys.com>,
<mark.rutland@arm.com>, <mcoquelin.stm32@gmail.com>,
<peppe.cavallaro@st.com>
Cc: <linux-stm32@st-md-mailman.stormreply.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>
Subject: Re: [PATCH 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build
Date: Thu, 3 Oct 2019 12:14:06 +0200 [thread overview]
Message-ID: <3715b72a-4b7c-32f4-a037-94d2862ad07d@st.com> (raw)
In-Reply-To: <20190920053817.13754-3-christophe.roullier@st.com>
Hi,
On 9/20/19 7:38 AM, Christophe Roullier wrote:
> This patch fix the following warning:
>
> warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
> int val, ret;
>
> Signed-off-by: Christophe Roullier <christophe.roullier@st.com>
> ---
Acked-by: Alexandre TORGUE <alexandre.torgue@st.com>
> drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> index 7e6619868cc1..167a5e99960a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> @@ -184,7 +184,7 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
> {
> struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
> u32 reg = dwmac->mode_reg;
> - int val, ret;
> + int val;
>
> switch (plat_dat->interface) {
> case PHY_INTERFACE_MODE_MII:
> @@ -220,8 +220,8 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
> }
>
> /* Need to update PMCCLRR (clear register) */
> - ret = regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
> - dwmac->ops->syscfg_eth_mask);
> + regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
> + dwmac->ops->syscfg_eth_mask);
>
> /* Update PMCSETR (set register) */
> return regmap_update_bits(dwmac->regmap, reg,
>
next prev parent reply other threads:[~2019-10-03 10:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 5:38 [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization Christophe Roullier
2019-09-20 5:38 ` [PATCH 1/5] net: ethernet: stmmac: Add support for syscfg clock Christophe Roullier
2019-10-03 10:13 ` Alexandre Torgue
2019-09-20 5:38 ` [PATCH 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build Christophe Roullier
2019-10-03 10:14 ` Alexandre Torgue [this message]
2019-09-20 5:38 ` [PATCH 3/5] ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet Christophe Roullier
2019-09-20 5:38 ` [PATCH 4/5] ARM: dts: stm32: adjust slew rate for Ethernet Christophe Roullier
2019-09-20 5:38 ` [PATCH 5/5] ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power mode on stm32mp157c Christophe Roullier
2019-09-22 22:12 ` [PATCH 0/5] net: ethernet: stmmac: some fixes and optimization Jakub Kicinski
2019-09-23 7:46 ` Christophe ROULLIER
2019-10-25 9:17 ` Christophe ROULLIER
2019-10-03 10:16 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3715b72a-4b7c-32f4-a037-94d2862ad07d@st.com \
--to=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=christophe.roullier@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox