From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A831D747C for ; Mon, 21 Aug 2023 13:39:13 +0000 (UTC) Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EBCC5BC; Mon, 21 Aug 2023 06:39:11 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 37LDcSG91006626, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 37LDcSG91006626 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Aug 2023 21:38:28 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 21 Aug 2023 21:38:13 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 21 Aug 2023 21:38:12 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d]) by RTEXMBS04.realtek.com.tw ([fe80::e138:e7f1:4709:ff4d%5]) with mapi id 15.01.2375.007; Mon, 21 Aug 2023 21:38:12 +0800 From: Justin Lai To: Jiri Pirko CC: "kuba@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH net-next v5 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Thread-Topic: [PATCH net-next v5 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Thread-Index: AQHZ0crXtvCkECTdcEuScM6fwcV+uq/vccWAgAVSagA= Date: Mon, 21 Aug 2023 13:38:12 +0000 Message-ID: <371e0e25bee34ad7bf6f9fa44713ac1b@realtek.com> References: <20230818115501.209945-1-justinlai0215@realtek.com> <20230818115501.209945-2-justinlai0215@realtek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXMBS01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net > Fri, Aug 18, 2023 at 01:55:00PM CEST, justinlai0215@realtek.com wrote: > V>This patch is to add the ethernet device driver for the PCIe interface > V>of Realtek Automotive Ethernet Switch, > >applicable to RTL9054, RTL9068, RTL9072, RTL9075, RTL9068, RTL9071. > > > >Below is a simplified block diagram of the chip and its relevant interfa= ces. > > > > ************************* > > * * > > * CPU network device * > > * ____________ * > > * | | * > > * | PCIE Host | * > > ************************* > > || > > PCIE > > || > > **************************************** > > * | PCIE Endpoint | * > > * |---------------| * > > * | GMAC | * > > * |------| Realtek * > > * || RTL90xx Series * > > * || * > > * _____________||______________ * > > * | |MAC| | * > > * | |---| | * > > * | | * > > * | Ethernet Switch Core | * > > * | | * > > * | ----- ----- | * > > * | |MAC| ............|MAC| | * > > * |__|___|_____________|___|____| * > > * |PHY| ............|PHY| * > > * ----- ----- * > > *********||****************||*********** > > > >The block of the Realtek RTL90xx series is our entire chip > >architecture, the GMAC is connected to the switch core, and there is no > >PHY in between. In addition, this driver is mainly used to control GMAC,= but > does not control the switch core, so it is not the same as DSA. >=20 > [..] >=20 >=20 > >+ > >+#define NETIF_F_ALL_CSUM NETIF_F_CSUM_MASK > >+ > >+#define NETIF_F_HW_VLAN_RX NETIF_F_HW_VLAN_CTAG_RX #define > >+NETIF_F_HW_VLAN_TX NETIF_F_HW_VLAN_CTAG_TX >=20 > [..] >=20 > I see 3 essentials wrong from 10sec review: > 1) You don't cc people who commented your previous versions > 2) You don't respect 72cols for patch description text (checkpatch did > warn you, didn't it?) > 3) You are defining very odd macros like these 3 >=20 > No need to read any longer... Really, can't you please ask someone who kn= ows > to help you with the submission preparation? You are vasting time of peop= le :/ >=20 Thank you for your reply, I will re-check this driver and the content you m= entioned above.