From: David Ahern <dsahern@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: Colin Ian King <colin.king@canonical.com>,
Stephen Worley <sworley@cumulusnetworks.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH] [net-next] nexthop: fix enum type confusion
Date: Wed, 27 May 2020 07:50:09 -0600 [thread overview]
Message-ID: <3722aa2b-667d-eef2-b901-ef0ae943f8f2@gmail.com> (raw)
In-Reply-To: <20200527134755.978758-1-arnd@arndb.de>
On 5/27/20 7:47 AM, Arnd Bergmann wrote:
> Clang points out a mismatch between function arguments
> using a different enum type:
>
> net/ipv4/nexthop.c:841:30: error: implicit conversion from enumeration type 'enum nexthop_event_type' to different enumeration type 'enum fib_event_type' [-Werror,-Wenum-conversion]
> call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
> ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~
>
> This looks like a copy-paste error, so just use the intended
> type instead.
>
> Fixes: 8590ceedb701 ("nexthop: add support for notifiers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> net/ipv4/nexthop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Nate sent a fix a few hours ago:
https://lore.kernel.org/netdev/20200527080019.3489332-1-natechancellor@gmail.com/T/#u
prev parent reply other threads:[~2020-05-27 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:47 [PATCH] [net-next] nexthop: fix enum type confusion Arnd Bergmann
2020-05-27 13:50 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3722aa2b-667d-eef2-b901-ef0ae943f8f2@gmail.com \
--to=dsahern@gmail.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sworley@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).