From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E633C433EF for ; Wed, 9 Mar 2022 04:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229517AbiCIEtu (ORCPT ); Tue, 8 Mar 2022 23:49:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiCIEtr (ORCPT ); Tue, 8 Mar 2022 23:49:47 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D3A12155C02 for ; Tue, 8 Mar 2022 20:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646801328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yW1kWq855MoycbxENZXn/INYb5Qcrtgiwr9xtyGJCE=; b=BqcZKHSgPtV7wWEAkPYeiBzssX0Az1kSsBGdDEKxPjUvA7V2z5hV1mkVlg0JxvlQnA8Y/0 VxeVA6q+OC04lUufrR7TOzDd2br5jEc5uQFn3UPUaVLmPXn/5kFttwlcy4EvpivAPdlxTm heJyLu3qEqXVlYqzbPVjgnG3RREYeG8= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-286-bGhHYPXiNwm6p5OHLwA8YQ-1; Tue, 08 Mar 2022 23:48:46 -0500 X-MC-Unique: bGhHYPXiNwm6p5OHLwA8YQ-1 Received: by mail-pj1-f71.google.com with SMTP id mt1-20020a17090b230100b001beef010919so3041624pjb.7 for ; Tue, 08 Mar 2022 20:48:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7yW1kWq855MoycbxENZXn/INYb5Qcrtgiwr9xtyGJCE=; b=oP1BvixKSan2KVrxnopY6mzbEdgVdTztpZrEKLgRFTXa2GMeH0A6eM0XGUFK//ZzMO wWm6uuI2v3eooVaxzW7eLDofwI0HMDabXpHhoqX5QbXW/+qBf8P+z5kv5BlJTwCG3wrT 5Oed0OxW6jBVr7DigOaZrJbL2zisMEPRuZ/u1fFUP8dsZ9c28UI9qRdKMQGe/8d9nIBS m7GhyBCb1MZEIK/z+8l472PVQoti8m8ge3i9kDR6IDO0HsNYPebCQRB29gDPpzyvFrxE J6IB9oIKnVWTI9gGbIwmNvUCKXqaqk79jN4zW0NVgqfoDAbc6msW06mchVI9gGOGcMI2 xKag== X-Gm-Message-State: AOAM532vLXiU0V8Eh961SkDL9vDKOn4TZodGyfUXB9tjWyUOdy0S7VmD dpYKYGBTan1SP6BC5/dqwkkhTpTJMdR8fpZDXjisNzxpxclIxJhV85tJdUh6g8TYjIdclgVnpve CDahnY5tThgHSrlBV X-Received: by 2002:a17:90b:17ca:b0:1bf:6188:cc00 with SMTP id me10-20020a17090b17ca00b001bf6188cc00mr8597560pjb.2.1646801325726; Tue, 08 Mar 2022 20:48:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwosqJUOOIblsYGQ27dg95V2/uz330dPMJom2dl9RgGa8k3TOiXYiGNo7Wasa+ovCrQzyH4wQ== X-Received: by 2002:a17:90b:17ca:b0:1bf:6188:cc00 with SMTP id me10-20020a17090b17ca00b001bf6188cc00mr8597538pjb.2.1646801325443; Tue, 08 Mar 2022 20:48:45 -0800 (PST) Received: from [10.72.13.251] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id g15-20020a056a0023cf00b004e17e11cb17sm821341pfc.111.2022.03.08.20.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 20:48:44 -0800 (PST) Message-ID: <373494ae-825b-d573-012c-4e7d453934da@redhat.com> Date: Wed, 9 Mar 2022 12:48:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v7 01/26] virtio_pci: struct virtio_pci_common_cfg add queue_notify_data Content-Language: en-US To: Xuan Zhuo , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org References: <20220308123518.33800-1-xuanzhuo@linux.alibaba.com> <20220308123518.33800-2-xuanzhuo@linux.alibaba.com> From: Jason Wang In-Reply-To: <20220308123518.33800-2-xuanzhuo@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 在 2022/3/8 下午8:34, Xuan Zhuo 写道: > Add queue_notify_data in struct virtio_pci_common_cfg, which comes from > here https://github.com/oasis-tcs/virtio-spec/issues/89 > > For not breaks uABI, add a new struct virtio_pci_common_cfg_notify. > > Since I want to add queue_reset after queue_notify_data, I submitted > this patch first. > > Signed-off-by: Xuan Zhuo Acked-by: Jason Wang > --- > include/uapi/linux/virtio_pci.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h > index 3a86f36d7e3d..22bec9bd0dfc 100644 > --- a/include/uapi/linux/virtio_pci.h > +++ b/include/uapi/linux/virtio_pci.h > @@ -166,6 +166,13 @@ struct virtio_pci_common_cfg { > __le32 queue_used_hi; /* read-write */ > }; > > +struct virtio_pci_common_cfg_notify { > + struct virtio_pci_common_cfg cfg; > + > + __le16 queue_notify_data; /* read-write */ > + __le16 padding; > +}; > + > /* Fields in VIRTIO_PCI_CAP_PCI_CFG: */ > struct virtio_pci_cfg_cap { > struct virtio_pci_cap cap;