From: Jacob Keller <jacob.e.keller@intel.com>
To: <nicolas.dichtel@6wind.com>,
Anil Kaushik <anilkaushikwireless@gmail.com>,
<netdev@vger.kernel.org>
Cc: <netdev-bot+sashiko@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Ido Schimmel <idosch@nvidia.com>,
Jiri Pirko <jiri@resnulli.us>, Florian Westphal <fw@strlen.de>,
Mat Martineau <martineau@kernel.org>,
XingWang Xiang <v3rdant.xiang@gmail.com>,
Alice Ryhl <aliceryhl@google.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v4 1/2] genetlink: Reject joining multicast groups no family owns
Date: Tue, 3 Nov 2026 13:07:17 -0800 [thread overview]
Message-ID: <373673dc-9eff-4887-b70e-c0d7a17da301@intel.com> (raw)
In-Reply-To: <a62aabdc-aa69-4ee1-bf91-606539c6637e@6wind.com>
On 11/3/2026 9:54 AM, Nicolas Dichtel wrote:
> Le 03/11/2026 à 17:12, Anil Kaushik a écrit :
>> Yes, this is a behaviour change, and I missed it in the commit message.
>> A bind() mask with an unowned ID now fails with -ENOENT and joins
>> nothing. I don't know of a program that does this.
>>
>> Ido, Nicolas, is this OK to keep, or should bind() skip unowned IDs?
>> I can send a new version if needed.
> It's ok for me, but if a regression occurs, a fix will be needed.
> I let others speak.
>
> Nicolas
This sounds like it might fall under the "no breaking user space" even
if its quite silly... But I am not an expert here so I am not sure.
Thanks,
Jake
next prev parent reply other threads:[~2026-11-03 21:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 15:58 [PATCH net v4 0/2] genetlink: fix joining multicast groups no family owns Anil Kaushik
2026-11-02 15:58 ` [PATCH net v4 1/2] genetlink: Reject " Anil Kaushik
2026-11-03 16:00 ` netdev-bot+sashiko
2026-11-03 16:12 ` Anil Kaushik
2026-11-03 17:54 ` Nicolas Dichtel
2026-11-03 21:07 ` Jacob Keller [this message]
2026-11-02 15:58 ` [PATCH net v4 2/2] netlink: Check a group again if it was released while joining it Anil Kaushik
2026-11-03 16:00 ` netdev-bot+sashiko
2026-11-03 16:13 ` Anil Kaushik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=373673dc-9eff-4887-b70e-c0d7a17da301@intel.com \
--to=jacob.e.keller@intel.com \
--cc=aliceryhl@google.com \
--cc=anilkaushikwireless@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=v3rdant.xiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox