From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: Tom Herbert <tom@quantonium.net>
Cc: davem@davemloft.net, pablo@netfilter.org, laforge@gnumonks.org,
aschultz@tpip.net, netdev@vger.kernel.org, rohit@quantonium.net,
netdev-owner@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v6 net-next 05/12] gtp: Change to use gro_cells
Date: Thu, 26 Oct 2017 13:35:06 -0600 [thread overview]
Message-ID: <3760392e2813ec13d37430143f83571d@codeaurora.org> (raw)
In-Reply-To: <20171026190929.11619-6-tom@quantonium.net>
> @@ -611,6 +615,8 @@ static const struct net_device_ops gtp_netdev_ops =
> {
>
> static void gtp_link_setup(struct net_device *dev)
> {
> + struct gtp_dev *gtp = netdev_priv(dev);
> +
> dev->netdev_ops = >p_netdev_ops;
> dev->needs_free_netdev = true;
>
> @@ -630,6 +636,8 @@ static void gtp_link_setup(struct net_device *dev)
> sizeof(struct iphdr) +
> sizeof(struct udphdr) +
> sizeof(struct gtp0_header);
> +
> + gro_cells_init(>p->gro_cells, dev);
> }
>
Hi Tom
This needs a check in case the initialization failed and moved to
ndo_init().
Eric spotted a similar bug in rmnet and vxlan.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-10-26 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 19:09 [PATCH v6 net-next 00/12] gtp: Additional feature support - Part I Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 01/12] iptunnel: Add common functions to get a tunnel route Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 02/12] vxlan: Call common functions to get tunnel routes Tom Herbert
2017-10-31 11:40 ` kbuild test robot
2017-10-26 19:09 ` [PATCH v6 net-next 03/12] gtp: Call common functions to get tunnel routes and add dst_cache Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 04/12] iptunnel: Generalize tunnel update pmtu Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 05/12] gtp: Change to use gro_cells Tom Herbert
2017-10-26 19:35 ` Subash Abhinov Kasiviswanathan [this message]
2017-10-26 19:51 ` Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 06/12] gtp: Use goto for exceptions in gtp_udp_encap_recv funcs Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 07/12] gtp: udp recv clean up Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 08/12] gtp: Call function to update path mtu Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 09/12] gtp: Eliminate pktinfo and add port configuration Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 10/12] gtp: Experimental encapsulation of IPv6 packets Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 11/12] gtp: Experimental support encpasulating over IPv6 Tom Herbert
2017-10-26 19:09 ` [PATCH v6 net-next 12/12] gtp: Allow configuring GTP interface as standalone Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3760392e2813ec13d37430143f83571d@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=aschultz@tpip.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=laforge@gnumonks.org \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rohit@quantonium.net \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox