From: Jay Vosburgh <fubar@us.ibm.com>
To: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
eric.dumazet@gmail.com, shemminger@vyatta.com
Subject: Re: [PATCH v2 0/3] bonding: add the debugfs interface to see RLB hash table
Date: Wed, 08 Dec 2010 12:33:02 -0800 [thread overview]
Message-ID: <3778.1291840382@death> (raw)
In-Reply-To: <4CF89A00.8030902@jp.fujitsu.com>
Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
>Hi Jay,
>
>Thank you for your quick review. I update my patchset according to your comment.
>But I didn't take measures against your concern about seq_file. If I come up with
>a good idea, I'll correct it.
>
>--
>This patchset provides the debugfs facility to the bonding driver and
>the interface to see RLB hashtable in it.
>
> *[PATCH 1/3] bonding: add the debugfs facility to the bonding driver
> *[PATCH 2/3] bonding: migrate some macros from bond_alb.c to bond_alb.h
> *[PATCH 3/3] bonding: add the debugfs interface to see RLB hash table
After applying your patches to net-next-2.6, I'm seeing the
following crash when executing "rmmod bonding":
BUG: unable to handle kernel paging request at 6b6b6b9f
IP: [<c0201f11>] debugfs_remove_recursive+0x1e/0x11a
*pde = 00000000
Oops: 0000 [#1] PREEMPT SMP
last sysfs file: /sys/devices/virtual/net/bond0/flags
Modules linked in: bonding(-) ipv6 mperf microcode loop tg3 e1000 libphy sworks_agp agpgart edd ext3 mbcache jbd pata_serverworks mptspi mptscsih mptbase [last unloaded: speedstep_lib]
Pid: 5237, comm: rmmod Not tainted 2.6.37-rc1-cur+ #11 /eserver xSeries 335 -[8676GBX]-
EIP: 0060:[<c0201f11>] EFLAGS: 00010202 CPU: 2
EIP is at debugfs_remove_recursive+0x1e/0x11a
EAX: 6b6b6b6b EBX: f4d99480 ECX: 00000000 EDX: f3d5a5d4
ESI: f4d99950 EDI: f2d445b8 EBP: f4d03eb8 ESP: f4d03ea8
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process rmmod (pid: 5237, ti=f4d02000 task=f3d5a240 task.ti=f4d02000)
Stack:
f4d03ec0 f4d99480 f4d99950 f4d99000 f4d03ec0 f801dc05 f4d03ef4 f8015c5b
c0156ab6 f4d03ed8 c0134ff0 f4d9949c f4d03ee4 c037ec67 f4d99150 f4d03ef4
f4d99000 f4d03f20 f4d99000 f4d03f08 c030eafe f4d03f20 c0ce4140 f80233a4
Call Trace:
[<f801dc05>] ? bond_debug_unregister+0xe/0x10 [bonding]
[<f8015c5b>] ? bond_uninit+0x324/0x36d [bonding]
[<c0156ab6>] ? trace_hardirqs_on+0xb/0xd
[<c0134ff0>] ? local_bh_enable_ip+0x97/0xae
[<c037ec67>] ? _raw_spin_unlock_bh+0x2f/0x32
[<c030eafe>] ? rollback_registered_many+0x187/0x1fb
[<c030eb81>] ? unregister_netdevice_many+0xf/0x4d
[<c0318890>] ? __rtnl_link_unregister+0x56/0x8a
[<c0318f45>] ? rtnl_link_unregister+0x19/0x21
[<f801e32d>] ? bonding_exit+0x30/0x3c [bonding]
[<c0162ddc>] ? sys_delete_module+0x184/0x1dc
[<c01555fe>] ? put_lock_stats+0xd/0x22
[<c0155708>] ? lock_release_holdtime+0xf5/0xfa
[<c01a8fa3>] ? sys_munmap+0x39/0x3f
[<c037f098>] ? restore_all_notrace+0x0/0x18
[<c010294c>] ? sysenter_do_call+0x12/0x32
Code: fc ff 89 d8 e8 27 77 fc ff 5b 5e 5d c3 55 89 e5 57 89 c7 56 53 83 ec 04 85 c0 0f 84 01 01 00 00 8b 40 40 85 c0 0f 84 f6 00 00 00 <83> 78 34 00 0f 84 ec 00 00 00 8b 47 34 31 d2 89 fe 05 a4 00 00
EIP: [<c0201f11>] debugfs_remove_recursive+0x1e/0x11a SS:ESP 0068:f4d03ea8
CR2: 000000006b6b6b9f
---[ end trace e274f539dfd6ed30 ]---
This happens regardless of activity; e.g., "insmod bonding
mode=balance-alb" followed immediately by "rmmod bonding" generates the
above.
Any thoughts?
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2010-12-08 20:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 7:19 [PATCH v2 0/3] bonding: add the debugfs interface to see RLB hash table Taku Izumi
2010-12-03 7:21 ` [PATCH 1/3] bonding: add the debugfs facility to the bonding driver Taku Izumi
2010-12-10 1:17 ` Taku Izumi
2010-12-11 0:21 ` Jay Vosburgh
2010-12-11 0:23 ` David Miller
2010-12-13 5:09 ` Taku Izumi
2010-12-13 5:15 ` David Miller
2010-12-03 7:22 ` [PATCH 2/3] bonding: migrate some macros from bond_alb.c to bond_alb.h Taku Izumi
2010-12-13 5:03 ` Taku Izumi
2010-12-16 20:35 ` David Miller
2010-12-03 7:22 ` [PATCH 3/3] bonding: add the debugfs interface to see RLB hash table Taku Izumi
2010-12-13 5:04 ` Taku Izumi
2010-12-16 20:35 ` David Miller
2010-12-08 20:33 ` Jay Vosburgh [this message]
2010-12-09 10:43 ` [PATCH v2 0/3] " Taku Izumi
2010-12-10 1:24 ` Taku Izumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3778.1291840382@death \
--to=fubar@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).