From: Amit Kucheria <amit.kucheria@canonical.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: List Linux Kernel <linux-kernel@vger.kernel.org>,
Rob Herring <r.herring@freescale.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux@arm.linux.org.uk, s.hauer@pengutronix.de,
valentin.longchamp@epfl.ch, daniel@caiaq.de,
Dinh.Nguyen@freescale.com, bryan.wu@canonical.com
Subject: Re: [PATCHv2 08/11] fec: fix uninitialized rx buffer usage
Date: Wed, 3 Feb 2010 10:33:16 -0800 [thread overview]
Message-ID: <37786d4b1002031033s15d0b24et82c3f0e45112ae65@mail.gmail.com> (raw)
In-Reply-To: <fa686aa41002030846v5044d585w7f4291f89c4b7ad@mail.gmail.com>
On Wed, Feb 3, 2010 at 8:46 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
> <amit.kucheria@canonical.com> wrote:
>> From: Rob Herring <r.herring@freescale.com>
>>
>> The fec driver was enabling receive buffer descriptor without allocating
>> the buffers. Make sure the buffer descriptors are initialized to not
>> start receiving packets.
>>
>> Open also calls fec_restart after the rx buffers are allocated. With the code
>> in fec_restart, it zeroes out the buffer descriptors that have just been
>> setup.
>
> fec related patches 8 & 9 look okay to me.
>
> g.
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
Can I take that as an Acked-by?
next prev parent reply other threads:[~2010-02-03 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1265173246.git.amit.kucheria@verdurent.com>
[not found] ` <0511204199ab83aed2340e70a4639500c0528dab.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <9fa7a3c70c46a1f776c6520051481cff6525ef02.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <ccc89dd7a6035abf5a78680404a2b30b9e025353.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <ec63e5978fd5ac5d308ede5916e648ba925818eb.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <f10f79e7313ecdeeb59ab881795baedf2430c636.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <240f12ca87d7666f31263aabc620a9ec197cd8ff.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <752ae69adb57d4f73fa011ba380cea1b927b9c8b.1265173480.git.amit.kucheria@canonical.com>
[not found] ` <cover.1265173480.git.amit.kucheria@canonical.com>
2010-02-03 5:16 ` [PATCHv2 08/11] fec: fix uninitialized rx buffer usage Amit Kucheria
2010-02-03 16:46 ` Grant Likely
2010-02-03 18:33 ` Amit Kucheria [this message]
2010-02-03 18:38 ` Grant Likely
2010-02-03 20:23 ` Grant Likely
2010-02-03 5:16 ` [PATCHv2 09/11] fec: Add LAN8700 phy support Amit Kucheria
2010-02-03 5:16 ` [PATCHv2 10/11] fec: Add ARCH_MX5 as a dependency Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37786d4b1002031033s15d0b24et82c3f0e45112ae65@mail.gmail.com \
--to=amit.kucheria@canonical.com \
--cc=Dinh.Nguyen@freescale.com \
--cc=bryan.wu@canonical.com \
--cc=daniel@caiaq.de \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=r.herring@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).