Netdev List
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Kirill Tkhai <ktkhai@virtuozzo.com>, mkl@pengutronix.de
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, dev@kicherer.org
Subject: Re: [BUG/Q] can_pernet_exit() leaves devices on dead net
Date: Mon, 2 Apr 2018 17:28:15 +0200	[thread overview]
Message-ID: <377fbd8a-cd7e-2650-8efd-907cea0a0aee@hartkopp.net> (raw)
In-Reply-To: <d97f5629-6de5-0d24-8a48-01a612a39bc9@virtuozzo.com>

Hi Kirill, Marc,

I checked the code once more and added some debug output to the other 
parts in CAN notifier code.

In fact the code pointed to by both of you seems to be obsolete as I 
only wanted to be 'really sure' that no leftovers of the CAN filters at 
module unloading.


> Yes, this one looks good:
> https://marc.info/?l=linux-can&m=150169589119335&w=2
> 
> Regards,
> Kirill
> 

I was obviously too cautious ;-)

All tests I made resulted in the function iterating through all the CAN 
netdevices doing exactly nothing.

I'm fine with removing that stuff - but I'm not sure whether it's worth 
to push that patch to stable 4.12+ or even before 4.12 (without 
namespace support - and removing rcu_barrier() too).

Any opinions?

Best regards,
Oliver

  reply	other threads:[~2018-04-02 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 15:53 [BUG/Q] can_pernet_exit() leaves devices on dead net Kirill Tkhai
2018-03-05 13:59 ` Oliver Hartkopp
2018-03-05 15:22   ` Kirill Tkhai
2018-03-06 10:26     ` Oliver Hartkopp
2018-03-16  9:19       ` Kirill Tkhai
2018-04-02 15:28         ` Oliver Hartkopp [this message]
2018-04-02 15:36           ` Kirill Tkhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=377fbd8a-cd7e-2650-8efd-907cea0a0aee@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=dev@kicherer.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox