From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] netfilter: turn NF_HOOK into an inline function Date: Fri, 09 Oct 2015 15:15:59 +0200 Message-ID: <37905061.HAWoCKur8L@wuerfel> References: <201510092113.o4u2vjMD%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: kbuild-all@01.org, Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" , "David S. Miller" , netdev@vger.kernel.org To: kbuild test robot Return-path: In-Reply-To: <201510092113.o4u2vjMD%fengguang.wu@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Friday 09 October 2015 21:03:57 kbuild test robot wrote: > ^1da177e Linus Torvalds 2005-04-16 818 cb->rt_flags &= ~DN_RT_F_IE; > ^1da177e Linus Torvalds 2005-04-16 819 if (rt->rt_flags & RTCF_DOREDIRECT) > ^1da177e Linus Torvalds 2005-04-16 820 cb->rt_flags |= DN_RT_F_IE; > ^1da177e Linus Torvalds 2005-04-16 821 > 29a26a56 Eric W. Biederman 2015-09-15 822 return NF_HOOK(NFPROTO_DECNET, NF_DN_FORWARD, > 29a26a56 Eric W. Biederman 2015-09-15 @823 &init_net, NULL, skb, dev, skb->dev, > 8f40b161 David S. Miller 2011-07-17 824 dn_to_neigh_output); > ^1da177e Linus Torvalds 2005-04-16 825 > ^1da177e Linus Torvalds 2005-04-16 826 drop: > Ah, right. The 'dev' variable here is declared as #ifdef CONFIG_NETFILTER struct net_device *dev = skb->dev; #endif Apparently because the code produced the same warning as the ipv6 code. Removing the #ifdef here would make that code nicer and let us use my patch. Alternatively we could put the same #ifdef into IPV6 and not use the inline function. Any opinions? Arnd