From: David Ahern <dsahern@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>, David Miller <davem@davemloft.net>
Cc: Jianlin Shi <jishi@redhat.com>, Wei Wang <weiwan@google.com>,
Martin KaFai Lau <kafai@fb.com>,
Eric Dumazet <edumazet@google.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions
Date: Mon, 10 Jun 2019 15:38:06 -0600 [thread overview]
Message-ID: <37a62d04-0285-f6de-84b5-e1592c31a913@gmail.com> (raw)
In-Reply-To: <cover.1560016091.git.sbrivio@redhat.com>
On 6/8/19 12:12 PM, Stefano Brivio wrote:
> The commands 'ip -6 route list cache' and 'ip -6 route flush cache'
> don't work at all after route exceptions have been moved to a separate
> hash table in commit 2b760fcf5cfb ("ipv6: hook up exception table to store
> dst cache"). Fix that.
The breakage is the limited ability to remove exceptions. Yes, you can
delete a v6 exception route if you know it exists. Without the ability
to list them, you have to guess.
The ability to list exceptions was deleted 2 years ago with 4.15. So far
no one has complained that exceptions do not show up in route dumps.
Rather than perturb the system again and worse with different behaviors,
in dot releases of stable trees, I think it would be better to converge
on consistent behavior between v4 and v6. By that I mean without the
CLONED flag, no exceptions are returned (default FIB dump). With the
CLONED flag only exceptions are returned.
next prev parent reply other threads:[~2019-06-10 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 18:12 [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions Stefano Brivio
2019-06-08 18:12 ` [PATCH net v3 1/2] ipv6: Dump route exceptions too in rt6_dump_route() Stefano Brivio
2019-06-10 21:31 ` David Ahern
2019-06-10 21:45 ` Stefano Brivio
2019-06-10 21:47 ` David Ahern
2019-06-10 21:55 ` Stefano Brivio
2019-06-08 18:12 ` [PATCH net v3 2/2] ip6_fib: Don't discard nodes with valid routing information in fib6_locate_1() Stefano Brivio
2019-06-10 21:38 ` David Ahern [this message]
2019-06-10 21:50 ` [PATCH net v3 0/2] ipv6: Fix listing and flushing of cached route exceptions Martin Lau
2019-06-10 21:53 ` Stefano Brivio
2019-06-10 22:47 ` Stefano Brivio
2019-06-11 20:19 ` Martin Lau
2019-06-11 21:09 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a62d04-0285-f6de-84b5-e1592c31a913@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jishi@redhat.com \
--cc=kafai@fb.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).