From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79702C43381 for ; Mon, 25 Mar 2019 09:31:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BB112087F for ; Mon, 25 Mar 2019 09:31:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AbeVz+V/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730362AbfCYJbd (ORCPT ); Mon, 25 Mar 2019 05:31:33 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51195 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729597AbfCYJbd (ORCPT ); Mon, 25 Mar 2019 05:31:33 -0400 Received: by mail-wm1-f66.google.com with SMTP id z11so8135082wmi.0 for ; Mon, 25 Mar 2019 02:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SNxU7chQ3Q9V6QHH1qprBue3UVx6Qi1Yq6H5r431K84=; b=AbeVz+V/Ui0Te3o9JqfkKcRdwMovqapT23JUeri+QgO4VGrRMRfQ+u7aUhTBSuotBC YU8GqHGZmV1spDSW43VHM2K9wPp5YzLOAZyqsOG/4Gl33xgsES1MdPxBx5OEabbQUrBi 7oH7vCL9XGsOY5nCqXJG1Rfh4Sovkf7Z+2x/9EcHa/eQuLMEXFjl7IP47kZ5/lORsIvN IC/1ahCU9Y/NOySCuVCtUQb3axgHeJKZrkF9z4ELckTgnbt5yp2K8u3TK2sOKVmJYTjY 1PnolW4tesMwyFjg9WCMhwwllMY/oIOkeItfUzDEg6N0msy9+ozinHV108VN4a6B2b2W WI/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SNxU7chQ3Q9V6QHH1qprBue3UVx6Qi1Yq6H5r431K84=; b=k+g5FObGPb0djqcuSxRc1VMA0NQEQM8qKGOt3ZfhEcnHN0Pd5fkv7pY+8w+iNLWVra xHgO9auvy8MCRAWkLnGXHv2qPJSmdFJQmjXJbqrTIv5qL4gbYR+6rgNr8aE//jp1PD0U 5HyqPVsIEEUULecqLEqmKZaPbTV/A4SOzFxnClmSQcSe4D7Bz140zCCFngPxBv/XIlxx +20H+wF0G5E9uVRzU7VEBLkZXzVafirWx8ElsxEfEobIAoFPbblefP7VxIT3njBGO/DY NilYaFEIg9A1la+Z4oGRfclsA/or3NgsPVvYgSxGfMRpnhyJCkgC4F1qNsya2fTiQBQA NeNA== X-Gm-Message-State: APjAAAVbYbo3BpFUMs32nALVtH7vqiafgrwtObMrsDAQgRS5Pn3eAXQM +PELMaPRVXPUqRPUJD2EMzRnaLmm X-Google-Smtp-Source: APXvYqxjRTyC+FISe464TGMgeUevDiQ/E90kR1KxoLc/1faN3IKq7g63lAwDKFhIfDiNFOXsCwpH8g== X-Received: by 2002:a1c:9609:: with SMTP id y9mr2969975wmd.27.1553506292039; Mon, 25 Mar 2019 02:31:32 -0700 (PDT) Received: from [192.168.8.147] (59.86.136.77.rev.sfr.net. [77.136.86.59]) by smtp.gmail.com with ESMTPSA id k9sm16960450wru.55.2019.03.25.02.31.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 02:31:31 -0700 (PDT) Subject: Re: [PATCH v2] net: use bulk free in kfree_skb_list To: Felix Fietkau , netdev@vger.kernel.org Cc: davem@davemloft.net, brouer@redhat.com, fw@strlen.de References: <20190324165644.21303-1-nbd@nbd.name> <3d7fd814-9525-f0a6-95ff-cccc2de8ecd8@gmail.com> <283cb1b7-dc83-04fd-15c0-b4bfd2411cbc@nbd.name> From: Eric Dumazet Message-ID: <37b3be81-f86d-3805-10d3-177e66d8d8f7@gmail.com> Date: Mon, 25 Mar 2019 02:31:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <283cb1b7-dc83-04fd-15c0-b4bfd2411cbc@nbd.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/25/2019 02:09 AM, Felix Fietkau wrote: > On 2019-03-25 09:51, Eric Dumazet wrote: >> >> >> On 03/24/2019 09:56 AM, Felix Fietkau wrote: >>> Since we're freeing multiple skbs, we might as well use bulk free to save a >>> few cycles. Use the same conditions for bulk free as in napi_consume_skb. >>> >> >> I do not believe kfree_skb_list() is used in the fast path, so do we really >> need to make it so complex ? > mac80211 uses it to free the fraglist from A-MSDU aggregated packets in > the tx status path. That's one fast path where it gets used right now > and the reason it was showing up in my perf traces. This is not drop monitor friendly then.... TX completion should use consume_skb() or dev_kfree_skb() BTW, I wonder what drop-monitor signal bulk free is sending ?