From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B73E1D5CC1 for ; Thu, 20 Feb 2025 17:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740071811; cv=none; b=b4/yQeU8xSQPp1ccA9iIEZ1YVUx6pg5KOr169XLwZlsm2nH4QKm2eJ9snwS72J8pT3kblu9hEc9RpPlCYMPns7qIUw65BqabJX+m5cXks56N4aiV6axd/3Na57XtfaPzlkNi7viej5vmJ3O5Y9w6AA3C+kB0DpxWpntiWTnIfi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740071811; c=relaxed/simple; bh=244XeKEKX+5A8ehxHdeeLmwJwhJA1rgjh3BsIfR/8tM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mVn80J7Z0QHDrtc6eGiwZjxK4DMKNfhxza9TOHTj9vCLM52qnYtCr7j9DtmVqIDfS17Xng19vFy4EuA9bxqbEzYhot4TLyJKLg+8/4R9G0dm++w8NuvPH89wPo8xwJTjvFMF/0mqJCuvxjWDllRpreSdAR+j0cwY0NuQpDzaj78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=0dHwAlgy; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="0dHwAlgy" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3f3fa5699a1so589423b6e.0 for ; Thu, 20 Feb 2025 09:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1740071808; x=1740676608; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QcApaWVKSxQSIvLEEHhnSoFMNHumzt0nl4dOj28dnl0=; b=0dHwAlgykdXsqX1wYLYwXt2Ts6SA+KR2AVFl1WMrJgrYcqwb03g2FGq+gIlg79FlGl HxGhNcYVONWq8D+2KmxIXUuurbEKtF5vSXt6rNUzHDenwAPnne5yVzPmYKFhRUestJUt lnTuxe3XS4a+qI4UZdD/MqPZ/iSKemhkEga8k3sBjRsqEnrXSginVeTCQyBWYKjIrR1w 9m01GH1SD5LP5gObtGkv2JLIRP8g7Rttsrfda6eFuGk8j720J9T5rKunXb0SrEsRTrB5 PrpiTOkYk14eJuJrhMuJlOrg/UI8dDwO3e6bepwWbwqQZ92UqXDPipJ2wzSQTSeT1onq 5YJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740071808; x=1740676608; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QcApaWVKSxQSIvLEEHhnSoFMNHumzt0nl4dOj28dnl0=; b=lmZVBY5sxp79s900ByHEr0ommv9A252GO/AMqbKvqZ10RCnyQn1Seu6Q/2ADGvdEjI W4AoZyBYnDUh1QtXIGehon5OY4FxCjzAUZRLR7JgeislMoR2ntGvEjUtvYzJgsmaS1EJ 13upQ4fVWt5WB83P08/ZRk9+jH+M8RO7MGvOLDuTOlK2UMwH4jNlbbGMgK5qpxc4WZ50 mWgUDMPVMKF73MGAgDEMuprbhFjjmqZIqK6t9/Y85lZBeO/24DCGnHiZmuF06AkYcUSR 7ntyZecTbrh6qUeuPZRy2HDkuxdMnz+UbaiUL9ih4SPXFCJEs/SAt8BUGV9G84SxilKt B9tQ== X-Forwarded-Encrypted: i=1; AJvYcCWhPIAXyXu+NKNrYvMMza6RVU5lNGSNb9lNh6/AtCFtDn9UhUnBuj4qLq4rfRbjuQ6NXeKQRZk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1vfzNc2djQnGnJx15EXzvtmMCOIFSP7ZquOSb9OFKkoe9yVRj 3y2SR5aHTTFtOV60GNDSP529bKAccTyLjvPQ+6fTT5ZZvMABtv4TUZkopIIK8J4= X-Gm-Gg: ASbGncs/hJZYRhSdwj8+EH+m7AuupcmhsJlYqwqatYSjkI5uadIq5HG0XSc7i2lot8+ iW9QOJ4fP6oaA5iAvvl1+fUe30eieoOwdHbkxFdt1okVG6sWjCmzdzs8lMXphZjvUe/vxc/z8C8 eXTbE77cLH0rGfkY0Dxtx5V62n88yUHnF3w0GyYFv9OF2QS5U9m49KNvIEHO543wESewy/kYSab S6ZdMsndmHGrERJMIv5mewMv97DIpcD4Kp+6pdu9kNYjgpXVyEleMj3mwdUwnIFCA213bdC72r1 sijyV6YS9WMohWZjlMDb5gUOAOP1h7KCXI3vG+nXnYFJfPaSrINM X-Google-Smtp-Source: AGHT+IFQ4fpht1GK2L64Lff/K3FzPWt1QsXeXeofzfatOKhBNQXj463x1jUtS3u3WnZ5Fb1+N2LaOQ== X-Received: by 2002:a05:6808:3996:b0:3f4:205c:d9aa with SMTP id 5614622812f47-3f424701c1dmr163494b6e.21.1740071808115; Thu, 20 Feb 2025 09:16:48 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f3da962049sm5144033b6e.21.2025.02.20.09.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 09:16:46 -0800 (PST) Message-ID: <37dc5907-b04f-4879-8271-68e36a6a2924@baylibre.com> Date: Thu, 20 Feb 2025 11:16:44 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() To: Andy Shevchenko , Simon Horman Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?UTF-8?Q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> <20250220101742.GR1615191@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/20/25 6:06 AM, Andy Shevchenko wrote: > On Thu, Feb 20, 2025 at 12:17 PM Simon Horman wrote: >> On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote: > > ... > >> But when compiling with GCC 14.2.0 I see warnings that values >> is used uninitialised - bitmap_set_value8() appears to rely on >> it being so. > >> In file included from drivers/bus/ts-nbus.c:13: >> In function ‘bitmap_write’, >> inlined from ‘ts_nbus_reset_bus’ at drivers/bus/ts-nbus.c:111:2: >> ./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized] >> 818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start)); >> | ~~~^~~~~~~ > > Heh, the compiler is dumb. Even if it's not initialised we do not care. > > ... > > Wondering if the bitmap_write() will work better... > It is already using that: #define bitmap_set_value8(map, value, start) \ bitmap_write(map, value, start, BITS_PER_BYTE)