From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 859B73B38A4; Thu, 7 May 2026 16:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778170118; cv=none; b=fDoq7SZCvl+fYSNz/9Ahjcq+tlwbhfgZAAvUrTdyVYQIObK0RONZS5Tgy/eWXwbMVTiJFU5WOlSryqgUWmBnkI0tjKT0HXlCUGZ9G+Zy9d3SqKH/2eYRQgpMgsT1337HfUbDKLmZBkBac8mBGjNP/XPBbWBMLl7jtGmvJtwECYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778170118; c=relaxed/simple; bh=RY3ZhrJkHje4r1jufnaEPJRII5OPlMz9wlkUozkjHvs=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=ZQD723zpGQ2mNhWamJsTeJqzop4FiIm82QvwrIP3k9qqsXBC1jHRTWbPofdUQQr2fWgNR1WbOxKPMhVGVXkJd1j1Z0wNtLh+eqra0U9iDDfHy80AbPjTUNhNhepClELGKMXQFu+YNBJePrl7cKAmsyF3+COXBiovt7fFApFmb1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fTEeTm4r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fTEeTm4r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86B49C2BCC9; Thu, 7 May 2026 16:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778170118; bh=RY3ZhrJkHje4r1jufnaEPJRII5OPlMz9wlkUozkjHvs=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=fTEeTm4rpKFCG9FTUGob3ijEpxLuoDpyd1b9sNaBqW1o6F3HroHYw/FFlknHL02As hLrzx/Lj5WxqV/ip6kOeGso9w/Sk00mlyApkLEr1SdEP089DgRhbsLeDKgJCdjfrBw +jNIFupmthUGDLRmOXjLy4Bt85bm/2nlRBZWhDAVzeLgI0OUXBkxtgjomQW1S6dp2g FJUw3nkZQDWXqK12onkhnJFLfImgcqaGeyGqJjZ0QUR1Ty00HRHttO1ej2QOFbbCBp 3WRyHymmJ8dAVpilFmUDc8L0Xfv90vgdnC5OIiTTz9oinKXpHgckwKAqeQ8TFfq04T 2xx9HRlOJeWWg== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 97A6BF4006B; Thu, 7 May 2026 12:08:36 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Thu, 07 May 2026 12:08:36 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddutdejleduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedfvehhuhgt khcunfgvvhgvrhdfuceotggvlheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrh hnpeegheduieeiveevheelheelueeghffhtddtheelhfdutddtheeileetkeelvedtjeen ucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheptghhuhgtkhhlvghvvghrodhmvghsmhhtphgruhht hhhpvghrshhonhgrlhhithihqdduieefgeelleelheelqdefvdelkeeggedvfedqtggvlh eppehkvghrnhgvlhdrohhrghesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthho pedvvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepnhgvihhlsegsrhhofihnrd hnrghmvgdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghp thhtohepjhhirghnghhshhgrnhhlrghisehgmhgrihhlrdgtohhmpdhrtghpthhtohepvg guuhhmrgiivghtsehgohhoghhlvgdrtghomhdprhgtphhtthhopegrnhhnrgeskhgvrhhn vghlrdhorhhgpdhrtghpthhtohepfhhrvgguvghrihgtsehkvghrnhgvlhdrohhrghdprh gtphhtthhopehhohhrmhhssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjlhgrhiht ohhnsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorh hg X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 61786780077; Thu, 7 May 2026 12:08:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AJo0cZWtw0Z3 Date: Thu, 07 May 2026 18:08:16 +0200 From: "Chuck Lever" To: "Marco Crivellari" , linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org Cc: "Tejun Heo" , "Lai Jiangshan" , "Frederic Weisbecker" , "Sebastian Andrzej Siewior" , "Michal Hocko" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" Message-Id: <38019ee1-4a2e-40d3-81fe-f29551cca309@app.fastmail.com> In-Reply-To: <20260507130117.252825-1-marco.crivellari@suse.com> References: <20260507130117.252825-1-marco.crivellari@suse.com> Subject: Re: [PATCH v2] xprtrdma: Move long delayed work on system_dfl_long_wq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, May 7, 2026, at 3:01 PM, Marco Crivellari wrote: > Currently the code enqueue work items using {queue|mod}_delayed_work(), > using system_long_wq. This workqueue should be used when long works are > expected and it is a per-cpu workqueue. > > The function(s) end up calling __queue_delayed_work(), which set a glo= bal > timer that could fire anywhere, enqueuing the work where the timer fir= ed. > > Unbound works could benefit from scheduler task placement, to optimize > performance and power consumption. Long work shouldn't stick to a sing= le > CPU. > > Recently, a new unbound workqueue specific for long running work has > been added: > > =C2=A0=C2=A0=C2=A0=C2=A0c116737e972e ("workqueue: Add system_dfl_long_= wq for long unbound works") > > Since the workqueue work doesn't rely on per-cpu variables, there is no > obvious reason that justify the use of a per-cpu workqueue. So change > system_long_wq with system_dfl_long_wq so that the work may benefit fr= om > scheduler task placement. > > Signed-off-by: Marco Crivellari > --- > Changes in v2: > - Commit log improvements > > - Rebase on v7.1-rc2 > > Link to v1:=20 > https://lore.kernel.org/all/20260430085412.96961-1-marco.crivellari@su= se.com/ Reviewed-by: Chuck Lever --=20 Chuck Lever