From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 543E7C32750 for ; Tue, 13 Aug 2019 21:27:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 244CD2067D for ; Tue, 13 Aug 2019 21:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wl1r2AV6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbfHMV1B (ORCPT ); Tue, 13 Aug 2019 17:27:01 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36987 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbfHMV1A (ORCPT ); Tue, 13 Aug 2019 17:27:00 -0400 Received: by mail-wr1-f65.google.com with SMTP id z11so7172236wrt.4 for ; Tue, 13 Aug 2019 14:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RTskLAPvDb7EatTWvjmN3VlIPt7mYqxXmueT9MNt1yQ=; b=Wl1r2AV6iObpC+QL+nyOkA5XTTHpHZwesUvs6ImG7ZCZwchs4bAnXngosk7SMJnhVx vY0qtpf/F3ByLq/3kzpeCGthhms0mL4FCXwLqGobAK4jkZ7oUovHlc5u2pcF9d25uxyX gC/kKF2sogJYgC4NMMJXHrlnTirXftuioTy0R60e0cLElXq+V9r62vBrNLt03To7dHn/ 4Yw4gQSlMi19P/2B+SExWHLXxJg0S/SgnkzyjEctOjHLEtB/ZWoYmB3FuYp2EN1/26Te 0TBrBpCy4GX44/6I0TudMukJ2l1yvE537OglYdiy+2dHGkuwBmzWc2JJ7Bq/IX8LMYwi f09Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RTskLAPvDb7EatTWvjmN3VlIPt7mYqxXmueT9MNt1yQ=; b=NrBoRrlGYZrd4+wXrRY1C7Ez74kkBYrlVNLyRyaj5Y/maQHCEFDxee4Y/64qdU1sG8 9Yn5YaiKY/UPSBiKXZ2dt5ppT1jpC3o4HLknNAsLev/1TRYQySc5xOQbgINc3xfUgxaa 9KLpbIi1aJgF1WH22j5GYe5NXxGc3FboSozBcOYpGnpsN9o3vLdfrbuXsQEiR1e+ipbV KrPWn9wrVeX8rJer/Xwn/ER8JZQWKMoLZ3MNsV7bnTNzNLOQnuSbxAi7KthuF2BhNurt B+hBqPaI3sV5VTQ+/U9wb9nxAdcl4z6lU8xS4B6wCPUtgXVsOtNhVYF/XWII0lINOaeT m/bg== X-Gm-Message-State: APjAAAXPyHgCcWl45JFyzsG7SZefC+SjKkjIHoX6L4ltnebEejJEd2QO iD5foepE8Se8QhRJw3yNim8TrDpP X-Google-Smtp-Source: APXvYqxzNdq82S/w2vxf1Z97MSLWS/X4H1IeQYSKzyE7I69PhCueXyJGQF9wpvZ6poFG0meH2NhNTA== X-Received: by 2002:adf:eec5:: with SMTP id a5mr25633399wrp.352.1565731617603; Tue, 13 Aug 2019 14:26:57 -0700 (PDT) Received: from ?IPv6:2003:ea:8f2f:3200:e1e2:64b7:ee24:2d4a? (p200300EA8F2F3200E1E264B7EE242D4A.dip0.t-ipconnect.de. [2003:ea:8f2f:3200:e1e2:64b7:ee24:2d4a]) by smtp.googlemail.com with ESMTPSA id o126sm4567187wmo.1.2019.08.13.14.26.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 14:26:57 -0700 (PDT) Subject: [PATCH RFC 4/4] net: phy: fixed_phy: let genphy driver set supported and advertised modes From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , Marek Behun , David Miller Cc: "netdev@vger.kernel.org" References: Message-ID: <38040623-d599-815e-6545-5c2138331fc2@gmail.com> Date: Tue, 13 Aug 2019 23:26:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A fixed phy as special swphy binds to the genphy driver that calls genphy_read_abilities(). This function populates the supported and advertised modes, so we don't have to do it manually. Signed-off-by: Heiner Kallweit --- drivers/net/phy/fixed_phy.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 7c5265fd2..db4d96f2f 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -282,29 +282,6 @@ static struct phy_device *__fixed_phy_register(unsigned int irq, phy->mdio.dev.of_node = np; phy->is_pseudo_fixed_link = true; - switch (status->speed) { - case SPEED_1000: - linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, - phy->supported); - linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, - phy->supported); - /* fall through */ - case SPEED_100: - linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, - phy->supported); - linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, - phy->supported); - /* fall through */ - case SPEED_10: - default: - linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT, - phy->supported); - linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Full_BIT, - phy->supported); - } - - phy_advertise_supported(phy); - ret = phy_device_register(phy); if (ret) { phy_device_free(phy); -- 2.22.0