From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>, mq@ucw.cz
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dsa@cumulusnetworks.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.
Date: Fri, 12 May 2017 10:26:08 -0700 [thread overview]
Message-ID: <3828cf04-1bf8-92d2-dfc4-184bd615fe10@gmail.com> (raw)
In-Reply-To: <20170512.112447.1421545301592945998.davem@davemloft.net>
On 5/12/17 8:24 AM, David Miller wrote:
> From: Jan Moskyto Matejka <mq@ucw.cz>
> Date: Fri, 12 May 2017 13:15:10 +0200
>
>> -int rt6_dump_route(struct rt6_info *rt, void *p_arg);
>> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate);
>
> Please use "bool" and "true"/"false" for boolean values.
>
> What does ipv4 do in this situation?
>
> I'm hesitant to be OK with adding a new nlmsg flag just for this case
> if we solve this problem differently and using existing mechanisms
> elsewhere.
>
I'll take a look at this later today or this weekend; we can't just
truncate the route returned to userspace.
next prev parent reply other threads:[~2017-05-12 17:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 11:15 [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer Jan Moskyto Matejka
2017-05-12 15:24 ` David Miller
2017-05-12 17:26 ` David Ahern [this message]
2017-05-12 17:34 ` David Miller
2017-05-12 21:41 ` Jan Moskyto Matejka
2017-05-13 6:52 ` David Ahern
2017-05-13 10:54 ` Jan Moskyto Matejka
2017-05-13 17:13 ` David Ahern
2017-05-13 17:29 ` Jan Moskyto Matejka
2017-05-14 21:00 ` Johannes Berg
2017-05-14 22:14 ` David Ahern
2017-05-14 22:20 ` Johannes Berg
2017-05-12 21:34 ` Jan Moskyto Matejka
2017-05-12 21:43 ` Jan Moskyto Matejka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3828cf04-1bf8-92d2-dfc4-184bd615fe10@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mq@ucw.cz \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).