From: Paolo Abeni <pabeni@redhat.com>
To: Johannes Berg <johannes.berg@intel.com>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Jakub Kicinski <kuba@kernel.org>,
b43-dev@lists.infradead.org, libertas-dev@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>
Subject: Re: [PATCH 0/4] drivers/net: replace __get_free_pages() with kmalloc()
Date: Wed, 8 Jul 2026 10:55:51 +0200 [thread overview]
Message-ID: <3832c190-b5b7-49a2-902d-7f75598b0789@redhat.com> (raw)
In-Reply-To: <20260701-b4-drivers-wireless-v1-0-60264cdf2efe@kernel.org>
On 7/1/26 3:59 PM, Mike Rapoport (Microsoft) wrote:
> This is a (small) part of larger work of replacing page allocator calls
> with kmalloc.
>
> My initial intention a few month ago was to remove ugly casts [1], but then
> willy pointed out that Linus objected to something like this [2] and it
> looks like more than a decade old technical debt.
>
> Largely, anything that doesn't need struct page (or a memdesc in the
> future) should just use kmalloc() or kvmalloc() to allocate memory.
> kmalloc() guarantees alignment, physical contiguity and working
> virt_to_phys() and beside nicer API that returns void * on alloc and
> doesn't require to know the allocation size on free, kmalloc() provides
> better debugging capabilities than page allocator.
>
> Another thing is that touching these allocation sites gives the reviewers
> opportunity to see if a PAGE_SIZE buffer is actually needed or maybe
> another size is appropriate.
>
> For larger allocations that don't need physically contiguous memory
> kvmalloc() can be a better option that __get_free_pages() because under
> memory pressure it's is easier to allocate several order-0 pages than a
> physically contiguous chunk with the same number of pages.
>
> And last, but not least, removing needless calls to page allocator should
> help with memdesc (aka project folio) conversion. There will be way less
> places to audit to see if the user was actually using struct page.
>
> Also in git:
> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git gfp-to-kmalloc/drivers-net-wireless
>
> [1] https://lore.kernel.org/all/20251018093002.3660549-1-rppt@kernel.org/
> [2] https://lore.kernel.org/all/CA+55aFwp4iy4rtX2gE2WjBGFL=NxMVnoFeHqYa2j1dYOMMGqxg@mail.gmail.com/
>
> ---
@Johannes: just an head-up, I assume this series will go via your tree
(despite the slightly misleading subj)
/P
next prev parent reply other threads:[~2026-07-08 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:59 [PATCH 0/4] drivers/net: replace __get_free_pages() with kmalloc() Mike Rapoport (Microsoft)
2026-07-01 13:59 ` [PATCH 1/4] b43, b43legacy: debugfs: use kzalloc() to allocate formatting buffers Mike Rapoport (Microsoft)
2026-07-01 13:59 ` [PATCH 2/4] libertas: " Mike Rapoport (Microsoft)
2026-07-01 13:59 ` [PATCH 3/4] mwifiex: " Mike Rapoport (Microsoft)
2026-07-01 16:24 ` Francesco Dolcini
2026-07-01 13:59 ` [PATCH 4/4] wlcore: allocate aggregation and firmware log buffers with kzalloc() Mike Rapoport (Microsoft)
2026-07-07 14:46 ` [PATCH 0/4] drivers/net: replace __get_free_pages() with kmalloc() Simon Horman
2026-07-08 8:55 ` Paolo Abeni [this message]
2026-07-08 9:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3832c190-b5b7-49a2-902d-7f75598b0789@redhat.com \
--to=pabeni@redhat.com \
--cc=b43-dev@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox