From: Florian Fainelli <f.fainelli@gmail.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: Vladimir Oltean <olteanv@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix
Date: Fri, 19 Mar 2021 17:46:33 -0700 [thread overview]
Message-ID: <38346eab-9a83-12e6-ed87-53bcfae1e587@gmail.com> (raw)
In-Reply-To: <20210319235440.3b964108@kernel.org>
On 3/19/2021 3:54 PM, Marek Behún wrote:
> On Fri, 19 Mar 2021 15:14:52 -0700
> Florian Fainelli <f.fainelli@gmail.com> wrote:
>
>> On 3/19/2021 12:47 PM, Marek Behún wrote:
>>> On Fri, 19 Mar 2021 20:58:20 +0200
>>> Vladimir Oltean <olteanv@gmail.com> wrote:
>>>
>>>> On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote:
>>>>> We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane`
>>>>> to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE.
>>>>>
>>>>> All other occurances in this function are using the `lane` variable.
>>>>>
>>>>> It seems I forgot to change it at this one place after refactoring.
>>>>>
>>>>> Signed-off-by: Marek Behún <kabel@kernel.org>
>>>>> Fixes: de776d0d316f7 ("net: dsa: mv88e6xxx: add support for ...")
>>>>> ---
>>>>
>>>> Either do the Fixes tag according to the documented convention:
>>>> git show de776d0d316f7 --pretty=fixes
>>>
>>> THX, did not know about this.
>>>
>>>> Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")
>>>>
>>>> or even better, drop it.
>>>
>>> Why better to drop it?
>>
>> To differentiate an essential/functional fix from a cosmetic fix. If all
>> cosmetic fixes got Fixes: tag that would get out of hands quickly.
>
> IMO in this case the Fixes tag is not necessary beacuse the base commit
> is not in any stable kernel yet.
This is not necessarily an argument that I would use, even if the commit
you are fixing is only in net-next, when it is a functional, and the
emphasis on the functional aspect of the code, providing a Fixes: tag is
really nice as it allows people that do backports or else to identify
the commits as an ensemble.
>
> But if the base commit was in a stable kernel already, and this
> cosmetic fix was sent into net-next / net, I think the Fixes tag should
> be there, in order for it to get applied into stable releases so that
> future fixes could be applied cleanly.
>
> Or am I wrong? This is how I understand this whole system...
Your reasoning is not wrong, for cosmetic changes that do not result in
functional changes, I would say that the Fixes: is optional.
--
Florian
prev parent reply other threads:[~2021-03-20 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 14:31 [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix Marek Behún
2021-03-19 18:35 ` Andrew Lunn
2021-03-19 18:58 ` Vladimir Oltean
2021-03-19 19:47 ` Marek Behún
2021-03-19 22:14 ` Florian Fainelli
2021-03-19 22:54 ` Marek Behún
2021-03-20 0:46 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38346eab-9a83-12e6-ed87-53bcfae1e587@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).