From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Tobias Jungel <tobias.jungel@gmail.com>
Cc: Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: fix length of actor system
Date: Sat, 27 Oct 2018 15:45:44 -0700 [thread overview]
Message-ID: <386.1540680344@nyx> (raw)
In-Reply-To: <909d24e39a29f9b5a7e7df171ebaa60e822bd90c.camel@gmail.com>
Tobias Jungel <tobias.jungel@gmail.com> wrote:
>The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the
>length of sizeof(bond->params.ad_actor_system) which is 8 byte. This
>patch aligns the length to ETH_ALEN to have the same MAC address exposed
>as using sysfs.
>
>fixes f87fda00b6ed2
>
>Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
The patch looks fine to me, but the "fixes" line is not
formatted properly. Please format it according to
Documentation/process/submitting-patches.rst
and resubmit your patch as V2.
-J
>---
> drivers/net/bonding/bond_netlink.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
>index 9697977b80f0..6b9ad8673218 100644
>--- a/drivers/net/bonding/bond_netlink.c
>+++ b/drivers/net/bonding/bond_netlink.c
>@@ -638,8 +638,7 @@ static int bond_fill_info(struct sk_buff *skb,
> goto nla_put_failure;
>
> if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM,
>- sizeof(bond->params.ad_actor_system),
>- &bond->params.ad_actor_system))
>+ ETH_ALEN, &bond->params.ad_actor_system))
> goto nla_put_failure;
> }
> if (!bond_3ad_get_active_agg_info(bond, &info)) {
>
---
-Jay Vosburgh, jay.vosburgh@canonical.com
next prev parent reply other threads:[~2018-10-28 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 13:31 [PATCH] bonding: fix length of actor system Tobias Jungel
2018-10-27 22:45 ` Jay Vosburgh [this message]
2018-10-28 11:54 ` [PATCH v2] " Tobias Jungel
2018-10-30 3:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=386.1540680344@nyx \
--to=jay.vosburgh@canonical.com \
--cc=andy@greyhouse.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=tobias.jungel@gmail.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).