From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jay Vosburgh Subject: Re: [PATCH] bonding: fix length of actor system Date: Sat, 27 Oct 2018 15:45:44 -0700 Message-ID: <386.1540680344@nyx> References: <909d24e39a29f9b5a7e7df171ebaa60e822bd90c.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: Veaceslav Falico , Andy Gospodarek , Eric Dumazet , netdev@vger.kernel.org To: Tobias Jungel Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:55890 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727107AbeJ1H2L (ORCPT ); Sun, 28 Oct 2018 03:28:11 -0400 In-reply-to: <909d24e39a29f9b5a7e7df171ebaa60e822bd90c.camel@gmail.com> Content-ID: <385.1540680344.1@nyx> Sender: netdev-owner@vger.kernel.org List-ID: Tobias Jungel wrote: >The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the >length of sizeof(bond->params.ad_actor_system) which is 8 byte. This >patch aligns the length to ETH_ALEN to have the same MAC address exposed >as using sysfs. > >fixes f87fda00b6ed2 > >Signed-off-by: Tobias Jungel The patch looks fine to me, but the "fixes" line is not formatted properly. Please format it according to Documentation/process/submitting-patches.rst and resubmit your patch as V2. -J >--- > drivers/net/bonding/bond_netlink.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c >index 9697977b80f0..6b9ad8673218 100644 >--- a/drivers/net/bonding/bond_netlink.c >+++ b/drivers/net/bonding/bond_netlink.c >@@ -638,8 +638,7 @@ static int bond_fill_info(struct sk_buff *skb, > goto nla_put_failure; > > if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM, >- sizeof(bond->params.ad_actor_system), >- &bond->params.ad_actor_system)) >+ ETH_ALEN, &bond->params.ad_actor_system)) > goto nla_put_failure; > } > if (!bond_3ad_get_active_agg_info(bond, &info)) { > --- -Jay Vosburgh, jay.vosburgh@canonical.com