From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bryan Wu" Subject: Re: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin Date: Mon, 13 Oct 2008 17:51:07 +0800 Message-ID: <386072610810130251k3699a8f0lcbcfc67c6c1364b4@mail.gmail.com> References: <1223889009-31336-1-git-send-email-cooloney@kernel.org> <20081013091725.GG31627@trinity.fluff.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ben@simtec.co.uk, s.hauer@pengutronix.de, jeff@garzik.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Javier Herrero" To: "Ben Dooks" Return-path: Received: from mail-gx0-f16.google.com ([209.85.217.16]:63742 "EHLO mail-gx0-f16.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932197AbYJMJvI (ORCPT ); Mon, 13 Oct 2008 05:51:08 -0400 Received: by gxk9 with SMTP id 9so3346068gxk.13 for ; Mon, 13 Oct 2008 02:51:07 -0700 (PDT) In-Reply-To: <20081013091725.GG31627@trinity.fluff.org> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Oct 13, 2008 at 5:17 PM, Ben Dooks wrote: > On Mon, Oct 13, 2008 at 05:10:09PM +0800, Bryan Wu wrote: >> From: Javier Herrero > > No, your arch definitions of writesb and co are wrong if they > are not taking 'void __iomem *' arguments. > Right, we should check the I/O functions and make them support "void __iomem *" arguments. Thanks -Bryan >> Signed-off-by: Javier Herrero >> Signed-off-by: Bryan Wu >> --- >> drivers/net/dm9000.c | 12 ++++++------ >> 1 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c >> index f42c23f..c4737ca 100644 >> --- a/drivers/net/dm9000.c >> +++ b/drivers/net/dm9000.c >> @@ -188,35 +188,35 @@ iow(board_info_t * db, int reg, int value) >> >> static void dm9000_outblk_8bit(void __iomem *reg, void *data, int count) >> { >> - writesb(reg, data, count); >> + writesb((int)reg, data, count); >> } >> >> static void dm9000_outblk_16bit(void __iomem *reg, void *data, int count) >> { >> - writesw(reg, data, (count+1) >> 1); >> + writesw((int)reg, data, (count+1) >> 1); >> } >> >> static void dm9000_outblk_32bit(void __iomem *reg, void *data, int count) >> { >> - writesl(reg, data, (count+3) >> 2); >> + writesl((int)reg, data, (count+3) >> 2); >> } >> >> /* input block from chip to memory */ >> >> static void dm9000_inblk_8bit(void __iomem *reg, void *data, int count) >> { >> - readsb(reg, data, count); >> + readsb((int)reg, data, count); >> } >> >> >> static void dm9000_inblk_16bit(void __iomem *reg, void *data, int count) >> { >> - readsw(reg, data, (count+1) >> 1); >> + readsw((int)reg, data, (count+1) >> 1); >> } >> >> static void dm9000_inblk_32bit(void __iomem *reg, void *data, int count) >> { >> - readsl(reg, data, (count+3) >> 2); >> + readsl((int)reg, data, (count+3) >> 2); >> } >> >> /* dump block from chip to null */ >> -- >> 1.5.6 > > -- > -- > Ben > > Q: What's a light-year? > A: One-third less calories than a regular year. > >