From: Paolo Abeni <pabeni@redhat.com>
To: Ratheesh Kannoth <rkannoth@marvell.com>, netdev-bot+sashiko@kernel.org
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, andrew+netdev@lunn.ch, ast@kernel.org,
daniel@iogearbox.net, davem@davemloft.net, edumazet@kernel.org,
hawk@kernel.org, john.fastabend@gmail.com, kuba@kernel.org,
sdf@fomichev.me, sgoutham@marvell.com
Subject: Re: [PATCH v19 net-next 2/2] octeontx2: add mqprio bandwidth offload for NIX TX schedulers
Date: Tue, 13 Oct 2026 16:05:40 +0200 [thread overview]
Message-ID: <38ae4fa2-29e5-49a7-8653-88f5a73593dd@redhat.com> (raw)
In-Reply-To: <asxY6cs5os_q3mAA@rkannoth-OptiPlex-7090>
On 10/12/26 05:50, Ratheesh Kannoth wrote:
> On 2026-10-10 at 15:31:10, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:
>> Thank you for your contribution! Sashiko AI review found 12 potential
>> issue(s) to consider.
>>
>> Critical: 0 · High: 1 · Medium: 9 (1) · Low: 2 (1)
>>
>> If you believe none of the issues are legitimate, please reply to each
>> issue of Medium severity or higher and explain why the AI is wrong.
>> If any of them are legitimate and you plan to respin, please let patchwork
>> know by including "pw-bot: cr" as a separate line at the end of your reply
>> (one such reply per series is enough).
>>
>> - [High] There is a use-after-free race on the deferred netdev_tc_work
>> during device removal.
>
> Not addressing this one; the window is theoretical and the impact is nil in practice.
The number of known valid issues that you intend not address is
concerning. Beyond the overall driver quality, please note that any
later patch touching this area will likely report the same issues,
require more effort from you to waive them and from us to actually
process the increasingly large wall of text.
I strongly suggest addressing at least the 'high' one and the others
with more straight-forward solutions.
/P
prev parent reply other threads:[~2026-10-13 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 9:43 [PATCH v19 net-next 0/2] octeontx2: mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-10-06 9:43 ` [PATCH v19 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags Ratheesh Kannoth
2026-10-10 10:01 ` netdev-bot+sashiko
2026-10-12 3:20 ` Ratheesh Kannoth
2026-10-13 10:55 ` Simon Horman
2026-10-06 9:43 ` [PATCH v19 net-next 2/2] octeontx2: add mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-10-10 10:01 ` netdev-bot+sashiko
2026-10-12 3:50 ` Ratheesh Kannoth
2026-10-13 10:56 ` Simon Horman
2026-10-13 14:05 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38ae4fa2-29e5-49a7-8653-88f5a73593dd@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rkannoth@marvell.com \
--cc=sdf@fomichev.me \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox