From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D55CC43381 for ; Sun, 17 Feb 2019 22:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD9BE2184E for ; Sun, 17 Feb 2019 22:38:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iYqti2ss" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbfBQWij (ORCPT ); Sun, 17 Feb 2019 17:38:39 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:43001 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfBQWij (ORCPT ); Sun, 17 Feb 2019 17:38:39 -0500 Received: by mail-pl1-f196.google.com with SMTP id s1so7724009plp.9 for ; Sun, 17 Feb 2019 14:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WgERZS9QJzE0UYfHncfe4WQ+6Grt22fyx528zC6I1EU=; b=iYqti2ssFEbPGb2EWaqER4aB8BVul7NtdY8vd9tcC0PSmmEFbZZdHpOI4dJtJUFW/T 8Hulc+9FWmUdjQ7uJJbRPHfGrtPcRunER6Dw/OPNpEaL12mRIwz2PSyzgrh223fAvbtx UWapwsgnxaiQVZIyJzlh1OaT6bduv6It64Z6hwZVi+rNxfCaODcUVwCea84vW59cRwU7 VfcWyXuiwgSX1FvBfsxmkCfEEa/SgtTIYpZ76fdoLmR/NL/8kmAajA+i6rrWLH1DXdBf I+zBEJGFrAVw36/n5cux3U2kkjeDgau08cC7X0iXeKmiywi9p5oRJ/0fEXZ6oNkiFGcf uNeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WgERZS9QJzE0UYfHncfe4WQ+6Grt22fyx528zC6I1EU=; b=ZAc2HSQqkbnBKKfOJa1Ovz/Vw6YcyRkYfPHl5l7ByUx6IWYnw4qY8oKtW+sGv9PPhz jkImqSmsCKlmSclWipI3yotSSsqyAq2LJYYOw2QZ0iOtMW73LKQfu3Ufi5WeXx5BCtnG /HbygAh37/15LGGVkXRZA1jhxKuw4ITGtnGFje8/OkuJUk2ngUiXw43Eg8w15fyT7JMd CkZXFBFGeodS9cWMAikNaUw/YyNIJ56SqR0KWAHEsP7k5zt2IhZMbJXi0buf3GiLUpco axi+79kIJelG/xQdnA4t5mSw/vYKqAoi17o3Px8drnw9JYZizL1goFwHaRN643AumcxO FK1g== X-Gm-Message-State: AHQUAuZ3C84+tZYXVkKaGqxA3cIEZtVQHJW4ymL1/KSKruXk0+meukbu Rr5IIqjap6hzEygdV8hDIRc= X-Google-Smtp-Source: AHgI3IZbLpxFvSk/V+1H/g/AqXYcMIsgGqpPsCWUbGNtmrZq6uwp5E2BW0UnliLK4dFfbfZ8RX8QeQ== X-Received: by 2002:a17:902:780a:: with SMTP id p10mr22528243pll.54.1550443118437; Sun, 17 Feb 2019 14:38:38 -0800 (PST) Received: from [192.168.1.3] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id k1sm13552529pgq.45.2019.02.17.14.38.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Feb 2019 14:38:37 -0800 (PST) Subject: Re: [BUG] [FIX] net: dsa: oops in br_vlan_enabled To: Frank Wunderlich , netdev@vger.kernel.org, andrew@lunn.ch, Vivien Didelot References: From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: <38b4f192-7641-8d22-4691-0c5f994f3c55@gmail.com> Date: Sun, 17 Feb 2019 14:38:27 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/17/2019 11:05 AM, Frank Wunderlich wrote: > Hi Florian > > a user from Bananapi-forum has reported the oops and i had reproduced this and patched out this oops. > That means not that vlan in bridge works, only no crash. > > my kernel only conatins the second gmac dsa-patches for mt7530/bpi-r2 i've posted at the end of last year, but the oops also occur without them. > > have not changed bridge vlan-configuration by > > echo 1 > /sys/class/net/bridge_name/bridge/vlan_filtering > > maybe that vlan-objects/configuration is not passed through, but there should happen no oops. > > kernel-source is here: https://github.com/frank-w/BPI-R2-4.14/tree/4.19-main > > ps: please take me in CC so i can answer directly You were in the To: of my previous reply, let's move it back there since it has all context. -- Florian