From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Chris Mi <chrism@mellanox.com>, netdev@vger.kernel.org
Cc: xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
mawilcox@microsoft.com
Subject: Re: [patch net-next v2 2/3] net/sched: Change cls_flower to use IDR
Date: Wed, 30 Aug 2017 08:09:14 -0400 [thread overview]
Message-ID: <38cea4fa-1ca2-1055-0595-4febf3c08e27@mojatatu.com> (raw)
In-Reply-To: <1504074719-15147-3-git-send-email-chrism@mellanox.com>
On 17-08-30 02:31 AM, Chris Mi wrote:
> Currently, all filters with the same priority are linked in a doubly
> linked list. Every filter should have a unique handle. To make the
> handle unique, we need to iterate the list every time to see if the
> handle exists or not when inserting a new filter. It is time-consuming.
> For example, it takes about 5m3.169s to insert 64K rules.
>
> This patch changes cls_flower to use IDR. With this patch, it
> takes about 0m1.127s to insert 64K rules. The improvement is huge.
>
> But please note that in this testing, all filters share the same action.
> If every filter has a unique action, that is another bottleneck.
> Follow-up patch in this patchset addresses that.
>
> Signed-off-by: Chris Mi <chrism@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
BTW: I'd already acked this before but you left it out in this
version.
cheers,
jamal
next prev parent reply other threads:[~2017-08-30 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 6:31 [patch net-next v2 0/3] net/sched: Improve getting objects by indexes Chris Mi
2017-08-30 6:31 ` [patch net-next v2 1/3] idr: Add new APIs to support unsigned long Chris Mi
2017-08-30 6:31 ` [patch net-next v2 2/3] net/sched: Change cls_flower to use IDR Chris Mi
2017-08-30 12:09 ` Jamal Hadi Salim [this message]
2017-08-30 6:31 ` [patch net-next v2 3/3] net/sched: Change act_api and act_xxx modules " Chris Mi
2017-08-30 12:11 ` Jamal Hadi Salim
2017-08-31 1:05 ` Chris Mi
2017-08-30 21:39 ` [patch net-next v2 0/3] net/sched: Improve getting objects by indexes David Miller
2017-08-31 1:05 ` Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38cea4fa-1ca2-1055-0595-4febf3c08e27@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=chrism@mellanox.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=mawilcox@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox