From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Simon Horman <horms@kernel.org>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Robert Elliott <elliott@hpe.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix bug with suspend and rebuild
Date: Tue, 5 Mar 2024 07:28:56 +0100 [thread overview]
Message-ID: <38f55ddc-a991-45e5-b32e-941ab7f3c0bc@molgen.mpg.de> (raw)
In-Reply-To: <20240304230845.14934-1-jesse.brandeburg@intel.com>
Dear Jesse,
Thank you for your patch.
Am 05.03.24 um 00:08 schrieb Jesse Brandeburg:
> The ice driver would previously panic during suspend. This is caused
> from the driver *only* calling the ice_vsi_free_q_vectors() function by
> itself, when it is suspending. Since commit b3e7b3a6ee92 ("ice: prevent
> NULL pointer deref during reload") the driver has zeroed out
> num_q_vectors, and only restored it in ice_vsi_cfg_def().
>
> This further causes the ice_rebuild() function to allocate a zero length
> buffer, after which num_q_vectors is updated, and then the new value of
> num_q_vectors is used to index into the zero length buffer, which
> corrupts memory.
[…]
For the commit message summary I suggest to be more specific. Maybe:
ice: Fix memory corruption with suspend and rebuild
ice: Avoid 0-length buffer to fix memory corruption with suspend/rebuild
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
next prev parent reply other threads:[~2024-03-05 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 23:08 [PATCH iwl-net v1] ice: fix bug with suspend and rebuild Jesse Brandeburg
2024-03-05 6:28 ` Paul Menzel [this message]
2024-03-05 13:17 ` Simon Horman
2024-03-05 17:35 ` Jesse Brandeburg
2024-03-06 16:46 ` Maciej Fijalkowski
2024-03-06 16:56 ` Maciej Fijalkowski
2024-03-07 1:33 ` Jesse Brandeburg
2024-03-07 1:41 ` Jesse Brandeburg
2024-03-07 16:10 ` Maciej Fijalkowski
2024-03-07 16:11 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f55ddc-a991-45e5-b32e-941ab7f3c0bc@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elliott@hpe.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).