netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avigail Dahan <Avigailx.dahan@intel.com>
To: Chwee-Lin Choong <chwee.lin.choong@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Zdenek Bouska <zdenek.bouska@siemens.com>,
	Faizal Rahim <faizal.abdul.rahim@linux.intel.com>,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	"Simon Horman" <horms@kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Reduce TSN TX packet buffer from 7KB to 5KB per queue
Date: Mon, 29 Dec 2025 16:53:38 +0200	[thread overview]
Message-ID: <38f70791-56b6-4795-876d-b84df289dbd8@intel.com> (raw)
In-Reply-To: <20251204122150.23853-1-chwee.lin.choong@intel.com>



On 04/12/2025 14:21, Chwee-Lin Choong wrote:
> The previous 7 KB per queue caused TX unit hangs under heavy
> timestamping load. Reducing to 5 KB avoids these hangs and matches
> the TSN recommendation in I225/I226 SW User Manual Section 7.5.4.
> 
> The 8 KB “freed” by this change is currently unused. This reduction
> is not expected to impact throughput, as the i226 is PCIe-limited
> for small TSN packets rather than TX-buffer-limited.
> 
> Fixes: 0d58cdc902da ("igc: optimize TX packet buffer utilization for TSN mode")
> Reported-by: Zdenek Bouska <zdenek.bouska@siemens.com>
> Closes: https://lore.kernel.org/netdev/AS1PR10MB5675DBFE7CE5F2A9336ABFA4EBEAA@AS1PR10MB5675.EURPRD10.PROD.OUTLOOK.COM/
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Signed-off-by: Chwee-Lin Choong <chwee.lin.choong@intel.com>
> ---
> v1: https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20250918183811.31270-1-chwee.lin.choong@intel.com/
> 
> changelog:
> v1 -> v2
> - Elaborated commit message
> ---
>   drivers/net/ethernet/intel/igc/igc_defines.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 

Tested-by: Avigail Dahan <avigailx.dahan@intel.com>

      reply	other threads:[~2025-12-29 14:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 12:21 [PATCH iwl-net v2] igc: Reduce TSN TX packet buffer from 7KB to 5KB per queue Chwee-Lin Choong
2025-12-29 14:53 ` Avigail Dahan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38f70791-56b6-4795-876d-b84df289dbd8@intel.com \
    --to=avigailx.dahan@intel.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=chwee.lin.choong@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=faizal.abdul.rahim@linux.intel.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=zdenek.bouska@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).