From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liran Alon Subject: Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister Date: Tue, 4 Sep 2018 00:36:04 -0700 (PDT) Message-ID: <390fdef0-4a37-4f88-881a-941373aff563@default> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: , , , , , , , , To: Return-path: Received: from userp2120.oracle.com ([156.151.31.85]:49044 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbeIDMAN (ORCPT ); Tue, 4 Sep 2018 08:00:13 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: ----- yuehaibing@huawei.com wrote: > Fixes gcc '-Wunused-but-set-variable' warning: >=20 > drivers/net/net_failover.c: In function > 'net_failover_slave_unregister': > drivers/net/net_failover.c:598:35: warning: > variable 'primary_dev' set but not used [-Wunused-but-set-variable] >=20 > There should check the validity of 'slave_dev'. >=20 > Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") >=20 > Signed-off-by: YueHaibing > --- > v2: use WARN_ON_ONCE as Liran Alon suggested > --- > drivers/net/net_failover.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c > index 7ae1856..5a749dc 100644 > --- a/drivers/net/net_failover.c > +++ b/drivers/net/net_failover.c > @@ -603,6 +603,9 @@ static int net_failover_slave_unregister(struct > net_device *slave_dev, > =09primary_dev =3D rtnl_dereference(nfo_info->primary_dev); > =09standby_dev =3D rtnl_dereference(nfo_info->standby_dev); > =20 > +=09if (WARN_ON_ONCE(slave_dev !=3D primary_dev && slave_dev !=3D > standby_dev)) > +=09=09return -ENODEV; > + I prefer to put () around different conditions but that's just a matter of = taste. Reviewed-by: Liran Alon > =09vlan_vids_del_by_dev(slave_dev, failover_dev); > =09dev_uc_unsync(slave_dev, failover_dev); > =09dev_mc_unsync(slave_dev, failover_dev);