From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf] bpf: hash_map: decrement counter on error
Date: Tue, 3 Jul 2018 23:28:18 +0200
Message-ID: <39431a52-0da4-d15f-6bbb-664b80bbc683@iogearbox.net>
References: <1530276500-29765-1-git-send-email-mauricio.vasquez@polito.it>
 <5f2040dc-f661-8346-c32e-5ba11ad93ae9@iogearbox.net>
 <5fba5067-1ba0-6ab1-21fd-ad6945cb886d@polito.it>
 <20180703202849.dydvuwcc6bcvy57i@ast-mbp.dhcp.thefacebook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Alexei Starovoitov <ast@kernel.org>, netdev@vger.kernel.org
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Mauricio Vasquez <mauricio.vasquez@polito.it>
Return-path: <netdev-owner@vger.kernel.org>
Received: from www62.your-server.de ([213.133.104.62]:42485 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752839AbeGCV2V (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 3 Jul 2018 17:28:21 -0400
In-Reply-To: <20180703202849.dydvuwcc6bcvy57i@ast-mbp.dhcp.thefacebook.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 07/03/2018 10:28 PM, Alexei Starovoitov wrote:
> On Sun, Jul 01, 2018 at 11:33:58AM -0500, Mauricio Vasquez wrote:
>> On 06/30/2018 06:20 PM, Daniel Borkmann wrote:
>>> On 06/29/2018 02:48 PM, Mauricio Vasquez B wrote:
>>>> Decrement the number of elements in the map in case the allocation
>>>> of a new node fails.
>>>>
>>>> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
>>> Thanks for the fix, Mauricio!
>>>
>>> Could you reply with a Fixes: tag in order to track the commit originally
>>> introducing this bug?
>>
>> Sure Daniel,
>>
>> Fixes: 6c9059817432 ("bpf: pre-allocate hash map elements")
> 
> Good catch. Thanks for the fix.
> Acked-by: Alexei Starovoitov <ast@kernel.org>

Applied to bpf, thanks Mauricio!