From: "Adam Langley" <agl@imperialviolet.org>
To: "Ben Hutchings" <bhutchings@solarflare.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled
Date: Fri, 30 May 2008 12:11:44 -0700 [thread overview]
Message-ID: <396556a20805301211g7dd98ae7m185a356e611e81aa@mail.gmail.com> (raw)
In-Reply-To: <20080530190218.GD1743@solarflare.com>
On Fri, May 30, 2008 at 12:02 PM, Ben Hutchings
<bhutchings@solarflare.com> wrote:
> Putting an #ifdef..#endif in the middle of an if () is a bit nasty. Why not
> define md5 and set it to 0 if CONFIG_TCP_MD5SIG is not set? The compiler
> should be able to optimise it away if it's always initialised to 0.
That's a good point, thanks. Followup patch in a second...
AGL
--
Adam Langley agl@imperialviolet.org http://www.imperialviolet.org
next prev parent reply other threads:[~2008-05-30 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 18:40 [PATCH] Fix corrupt TCP packets when options space overflows with MD5SIG enabled Adam Langley
2008-05-30 19:02 ` Ben Hutchings
2008-05-30 19:11 ` Adam Langley [this message]
2008-05-30 19:17 ` Adam Langley
2008-05-30 20:32 ` Stephen Hemminger
2008-05-31 22:01 ` Adam Langley
2008-05-31 21:57 ` Adam Langley
2008-06-01 23:40 ` James Morris
2008-06-02 6:56 ` David Miller
2008-06-03 16:31 ` Adam Langley
2008-06-03 16:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396556a20805301211g7dd98ae7m185a356e611e81aa@mail.gmail.com \
--to=agl@imperialviolet.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).