From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4C51D5160 for ; Sat, 13 Jun 2026 08:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781338571; cv=none; b=ZkpG+tqw0LzUMZwrrQ0i7LqEv7UjizOGCqVtbNAfdVLO4z+OAIQj5orCpgUy29VeB1zrXvwfyVmThZ4j7N/SzCoV1n/isXN/c0tOW1e4Mrh9OZqLBQ9oGdfowOCif1Zbl0zY/FiEkbpC/5oxmJhFKZXfN7K6/fJ+s2NaPYr4OIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781338571; c=relaxed/simple; bh=gxXIQs4fOYo7UxbFqDXGSyWElu5qYAeUnrJUD0vklmg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hyvdqdz6ia9hIpZrjAx1Xy6/IEPQlbNh38bW3Qt7gO3IIefM5yxafFZsR0Simh54G4pbInsvGI1lEQy3LfojNoXP0QgkcABgqh3IEtf20FXBxDrmYj9Zy7FCpfscYn3DzdvDF4gXpFJgifsEW2ZrZidHV8u2IV6fh83nhqwwFPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T2+02RrX; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T2+02RrX" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5aa69131836so1588121e87.3 for ; Sat, 13 Jun 2026 01:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781338568; x=1781943368; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=0iXLstte6ButgpYOzogymHuOexokA1uZth6v7/qqcCo=; b=T2+02RrXMtMJCfwDyutG9OtBlzhRtcAQ00UNE81YQm+J0vWjlCsAZ5fEmKaUrPHWpX w9Heg/Vl3x60KBWHMFhkMVareUkFw8OdZhhVsykUpbgjyz2WL0nxrKLziYhAiTHxLoUG wYaKf7p4+iOG6UXbjV8X+lpNkmFvNGEh+d9TiblbGWZ1cz7TMwZJCkAvXCNQbJja6g7x A+swLSGRoQPkPnf4TXaIO+Ajo4xCEI7KCgj3RHC660LeH3+WQjuLZ+UytDGOeITK6sHK 0VPtn2dDCQ6/aGyyTw+9zBrCQ8UsAX68IoLHvSrJp3mdOC/hKPJ8yv4W7YBlCHiSU/WW P61w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781338568; x=1781943368; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0iXLstte6ButgpYOzogymHuOexokA1uZth6v7/qqcCo=; b=TGgFiV/0MitzzP7pN9DpuOUFXcTPZSKuMCJ/rhBaJxkEbwyIj6OYIRXvWJCWMEvGsJ LSbvdFXs2hq6koZFesJ4JPu46COzKf+0GAJN5FudkflJ+nCK+geYLubECRnqj9uvX8Kb gk7ENpnvUpR6f9is7Up1RUgnfZ962cflLNOa43/yeo8HoJs08g4+HtNNkyw954Md9Y8B fMpT9YIi5Dzg1Yfo3UCqqp/J/iPngPaIgQHNLL715CrxRXo59brZ5R89LWsIYz9wG4ok wJWKkf30GL666OxyRAYOlF9twK9sV0+xqDmySXseOea0IF73S61ZckNPwapux61cbQMq tuYg== X-Forwarded-Encrypted: i=1; AFNElJ/L6WF9nbcEYw7pGXwCyUrukH/xOgI8ufWtup6iwfPLwvMDHCATwQO6fEbgagSGDdU+6pIl+sU=@vger.kernel.org X-Gm-Message-State: AOJu0YxyeNUb8YDw/lvveh9w+ifHH5bXtu/bsIVeRBjO9L/HOWuSMmzu OF9tm73tnxtA1qKGWTU5y+JN008YcTqTxHdigltppVzPwxCRbL8nepkk X-Gm-Gg: Acq92OEIX4EUKouUQLc/3/GaDKMGO8aVfPhefVpSz6NSO+QwcVZqvQ+bj7/+8Udm/Zy nh2i2+UNq1IJ4sHXQnP8l0uh4V34Q+HBHlfGTpqjOjiaIJS52nw//ui4lAIxWM7Bnf8NvXYrXwN eVfYLqT8A3NRX/uWcKYSqJT1O/YMdY+JPUS4lV1rP9laZwkD20Ew2VX45nK0XNg+PVNxVC6t1a0 jCyr9nNgXEdT+nostNFzbGtvAVjkvWat6k5HzymHIG5VO/IxLoDFerOUxTcxWEt+FI8S1cJklo7 zMTS/IgukWPcKzQyu79Jjk6QhixpSLC1DPRYvw65PDNgZYPyNHPqms2ybwEO2jLB9304DSG+u5v 8D6ogHPyx0HO/qBAVC3ABSa2qq29ILtTU32jPVt/urQXqUJ7BXybNM3fY4ZIbGdFfGU/m48genZ 84rO35/P01D9HfmLNS4Sj+kT8tp12XQ+lfr4xRZhNh5gH66wCHXyreVCAgWBrzfpNOaAC10HGYu aXqoQ== X-Received: by 2002:a05:6512:4608:b0:5aa:5a89:c80b with SMTP id 2adb3069b0e04-5ad30dc08a1mr583841e87.30.1781338567680; Sat, 13 Jun 2026 01:16:07 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:856:c6e8:742c:af09:78ba:8005? ([2a00:1fa0:856:c6e8:742c:af09:78ba:8005]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e16935esm1124202e87.25.2026.06.13.01.16.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 01:16:06 -0700 (PDT) Message-ID: <39720384-28da-4157-8613-8f02ab890abf@gmail.com> Date: Sat, 13 Jun 2026 11:16:04 +0300 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next 9/9] net: ethernet: ravb: Add gPTP support for Gen4 To: =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Paul Barker , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Geert Uytterhoeven , Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260610102432.3538432-1-niklas.soderlund+renesas@ragnatech.se> <20260610102432.3538432-10-niklas.soderlund+renesas@ragnatech.se> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: <20260610102432.3538432-10-niklas.soderlund+renesas@ragnatech.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/10/26 1:24 PM, Niklas Söderlund wrote: > While driver advertise gPTP support on Gen4 platforms it is in fact Advertises. > completely broken. On R-Car Gen4 devices the RAVB module have no > internal gPTP clock as generations before it. Instead it utilizes a > system wide gPTP clock. > > This change utilizes the refactoring of the RAVB gPTP code to add > support for a system wide clock and stops the Gen4 devices trying to use System-wide? > the non-existing internal gPTP clock. > > To remain backward compatible the device tree property needed > (renesas,gptp) to get hold of the system gPTP clock is optional. If the Can't parse this statement... > property is not present, or not enabled, the RAVB driver will no longer > advertise gPTP support to user-space. > > Signed-off-by: Niklas Söderlund Reviewed-by: Sergey Shtylyov [...] > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index caad95a9c3c5..acdfb56bb135 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -249,6 +249,8 @@ enum APSR_BIT { > APSR_RDM = 0x00002000, > APSR_TDM = 0x00004000, > APSR_MIISELECT = 0x01000000, /* R-Car V4M only */ > + APSR_GPTPTIMER_SOURCE = BIT(25), /* Gen4 */ > + APSR_GPTPCLOCK = BIT(29), /* Gen4 */ Hum, the other *enum* entries don't use BIT()... [...] MBR, Sergey