From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae-Hyun Hwang Subject: Re: [PATCH] tcp: for tcp westwood implementation Date: Mon, 28 Dec 2009 19:52:23 +0900 Message-ID: <39ba5b880912280252y208eb8bby7b54289fcd3965af@mail.gmail.com> References: <39ba5b880912272235k3f9c4892gf02a727c8ddfc551@mail.gmail.com> <20091228084313.GA7302@ff.dom.local> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org To: Jarek Poplawski Return-path: Received: from mail-bw0-f227.google.com ([209.85.218.227]:43175 "EHLO mail-bw0-f227.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbZL1Kw0 convert rfc822-to-8bit (ORCPT ); Mon, 28 Dec 2009 05:52:26 -0500 Received: by bwz27 with SMTP id 27so6433599bwz.21 for ; Mon, 28 Dec 2009 02:52:23 -0800 (PST) In-Reply-To: <20091228084313.GA7302@ff.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: Is it still wrong? I hope this patch is successful. =46rom: Jae-Hyun Hwang Current net/ipv4/tcp_westwood.c seems to be unnatural when compared with Westwood papers. Since Linux TCP calls '.ssthresh' interface whenever packet loss is detected, it is more natural that the interface points to 'tcp_westwood_bw_rttmin' function, not Reno's function. This patch also enables Westwood to perform its algorithm when CA_EVENT_LOSS event is generated as explained in the papers. Signed-off-by: Jae-Hyun Hwang --- --- linux-2.6.32.2/net/ipv4/tcp_westwood.c.orig 2009-12-28 13:35:42.000000000 +0900 +++ linux-2.6.32.2/net/ipv4/tcp_westwood.c 2009-12-28 13:36:54.00000000= 0 +0900 @@ -232,12 +232,7 @@ static void tcp_westwood_event(struct so westwood_fast_bw(sk); break; - case CA_EVENT_COMPLETE_CWR: - tp->snd_cwnd =3D tp->snd_ssthresh =3D tcp_westwood_bw_rttmin(sk); - break; - case CA_EVENT_FRTO: - tp->snd_ssthresh =3D tcp_westwood_bw_rttmin(sk); /* Update RTT_min when next ack arrives */ w->reset_rtt_min =3D 1; break; @@ -274,9 +269,8 @@ static void tcp_westwood_info(struct soc static struct tcp_congestion_ops tcp_westwood =3D { .init =3D tcp_westwood_init, - .ssthresh =3D tcp_reno_ssthresh, + .ssthresh =3D tcp_westwood_bw_rttmin, .cong_avoid =3D tcp_reno_cong_avoid, - .min_cwnd =3D tcp_westwood_bw_rttmin, .cwnd_event =3D tcp_westwood_event, .get_info =3D tcp_westwood_info, .pkts_acked =3D tcp_westwood_pkts_acked, -- On Mon, Dec 28, 2009 at 5:43 PM, Jarek Poplawski wr= ote: > On 28-12-2009 07:35, Jae-Hyun Hwang wrote: >> I'm sorry about posting such a damaged email. >> I resubmit the patch by plain-text. > > Most probably it's still wrong (e.g. no tabs). > http://marc.info/?l=3Dlinux-netdev&m=3D126198215600946&q=3Draw > > Did you try to send it to yourself? > > Jarek P. > >> >> On Mon, Dec 28, 2009 at 2:56 PM, David Miller = wrote: >> - Hide quoted text - >>> Annyoung-haseyo, >>> >>> Your patch was damaged by your email client (long lines >>> were chopped up with newlines, etc.), as such it is not >>> usable. >>> >>> Please fix this up and resubmit your patch. >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe netdev" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at =C2=A0http://vger.kernel.org/majordomo-info.h= tml >> > > > >