From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"David S. Miller" <davem@davemloft.net>,
Network Development Mailing List <netdev@oss.sgi.com>
Subject: Re: [PATCH][NET] make all protos partially use sk_prot
Date: Sat, 26 Mar 2005 15:55:39 -0300 [thread overview]
Message-ID: <39e6f6c7050326105553789ae6@mail.gmail.com> (raw)
In-Reply-To: <1111854713.9195.202.camel@pegasus>
On Sat, 26 Mar 2005 17:31:53 +0100, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Arnaldo,
>
> > > Here is an updated patch, taking, I hope, all of Marcel
> > > considerations into account and also fixing a bug in proto_register,
> > > I was returning on error without dropping the lock.
> >
> > the error path of some init function in the Bluetooth subsystem is still
> > wrong.
Which one? I'll check...
>> And I don't really like your way of using the labels, because
> > this twists my brain too much.
Oh well, this is how things are done all over the place, but lets be fair
with your brain ;)
>> I fixed all of these and while we are at
> > it, I cleaned up the init functions. Please use the attached patch
> > instead of your changes to the Bluetooth subsystem.
Whatever, I'll cook up a new patch with your changes for bluetooth.
> oops, I forgot to include hci_sock.c into that patch. Here is a fixed
> one.
Regards,
- Arnaldo
next prev parent reply other threads:[~2005-03-26 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-26 14:45 [PATCH][NET] make all protos partially use sk_prot Arnaldo Carvalho de Melo
2005-03-26 16:22 ` Marcel Holtmann
2005-03-26 16:31 ` Marcel Holtmann
2005-03-26 18:55 ` Arnaldo Carvalho de Melo [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-03-26 23:23 Arnaldo Carvalho de Melo
2005-04-01 5:19 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e6f6c7050326105553789ae6@mail.gmail.com \
--to=arnaldo.melo@gmail.com \
--cc=acme@conectiva.com.br \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=marcel@holtmann.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).