From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: hadi@cyberus.ca
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"David S. Miller" <davem@davemloft.net>,
Ralf Baechle <ralf@linux-mips.org>, netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH 2/2][AX25] make ax25_queue_xmit a net_device parameter
Date: Mon, 4 Apr 2005 20:08:39 -0300 [thread overview]
Message-ID: <39e6f6c70504041608707cb02f@mail.gmail.com> (raw)
In-Reply-To: <1112645495.1078.40.camel@jzny.localdomain>
On 04 Apr 2005 16:11:36 -0400, jamal <hadi@cyberus.ca> wrote:
>
> You probably wanna set skb->input_dev in ax25_type_trans() as well
> something like:
> skb->input_dev = skb->dev = dev
Yup, forgot about this one in this patch, but I want right now is mostly to
reduce open coding all around while maintaining the same behaviour, in
time we can eventually see a better abstraction for this set of operations,
it should also set skb->protocol internally and not return a value to set
skb->protocol, etc. :-)
- Arnaldo
prev parent reply other threads:[~2005-04-04 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-04 19:50 [PATCH 2/2][AX25] make ax25_queue_xmit a net_device parameter Arnaldo Carvalho de Melo
2005-04-04 19:52 ` [AX25] Introduce ax25_type_trans. was " Arnaldo Carvalho de Melo
2005-04-04 20:11 ` jamal
2005-04-04 23:08 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e6f6c70504041608707cb02f@mail.gmail.com \
--to=arnaldo.melo@gmail.com \
--cc=acme@conectiva.com.br \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).