From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Riesch Subject: Re: [PATCH net-next 2/2] ptp: Fix compiler warnings in the testptp utility Date: Wed, 09 Apr 2014 08:15:40 +0200 Message-ID: <3BEC808C584DF40B07928928@[172.22.2.41]> References: <1395746646-28299-1-git-send-email-christian.riesch@omicron.at> <20140325114523.GB14836@netboy> <1396993385.2376.8.camel@jekeller-desk1.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Christian Riesch , netdev@vger.kernel.org, Dong Zhu To: "Keller, Jacob E" , Richard Cochran Return-path: Received: from mail-ee0-f50.google.com ([74.125.83.50]:49544 "EHLO mail-ee0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889AbaDIGPo (ORCPT ); Wed, 9 Apr 2014 02:15:44 -0400 Received: by mail-ee0-f50.google.com with SMTP id c13so1454136eek.9 for ; Tue, 08 Apr 2014 23:15:43 -0700 (PDT) In-Reply-To: <1396993385.2376.8.camel@jekeller-desk1.amr.corp.intel.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: --On April 08, 2014 21:43 +0000 "Keller, Jacob E" wrote: > On Tue, 2014-03-25 at 12:45 +0100, Richard Cochran wrote: >> On Tue, Mar 25, 2014 at 12:24:06PM +0100, Christian Riesch wrote: >> > Signed-off-by: Christian Riesch >> > Cc: Dong Zhu >> > --- >> > Documentation/ptp/testptp.c | 10 +++++----- >> > 1 file changed, 5 insertions(+), 5 deletions(-) >> > >> > diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c >> > index 13bddd5..14bf19e 100644 >> > --- a/Documentation/ptp/testptp.c >> > +++ b/Documentation/ptp/testptp.c >> > @@ -496,14 +496,14 @@ int main(int argc, char *argv[]) >> > interval = t2 - t1; >> > offset = (t2 + t1) / 2 - tp; >> > >> > - printf("system time: %ld.%ld\n", >> > + printf("system time: %lld.%u\n", >> > (pct+2*i)->sec, (pct+2*i)->nsec); >> > - printf("phc time: %ld.%ld\n", >> > + printf("phc time: %lld.%u\n", >> > (pct+2*i+1)->sec, (pct+2*i+1)->nsec); >> > - printf("system time: %ld.%ld\n", >> > + printf("system time: %lld.%u\n", >> > (pct+2*i+2)->sec, (pct+2*i+2)->nsec); >> > - printf("system/phc clock time offset is %ld ns\n" >> > - "system clock time delay is %ld ns\n", >> >> Use PRId64 instead? >> >> Thanks, >> Richard >> > > I agree with this. %lld is not going to resolve the error properly on a > 32 bit machine. Looks like a follow-on patch would have to be generated, > since Dave applied this already. Thanks for catching this. I read the "applied" message from David but didn't notice that he applied v1 of the patch, v2 was the one with PRId64. I'll prepare a follow-up patch. Christian